Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] Levelized cost sweep mode does not run if optimization_settings node is present #389

Open
10 tasks
GabrielSoto-INL opened this issue Nov 13, 2024 · 3 comments
Labels
defect Something isn't working

Comments

@GabrielSoto-INL
Copy link
Collaborator


Defect Description

When running a sweep run in HERON, if there is an optimization_settings node present in the Case node then HERON errors out. This should not happen, as we can run other sweep cases even if there are optimization_settings nodes present.

What did you expect to see happen?
What did you see instead?
Do you have a suggested fix for the development team?

Describe how to Reproduce
Steps to reproduce the behavior:
1.
2.
3.
4.

Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):

  • OS: [e.g. iOS]
  • Version: [e.g. 22]
  • Dependencies Installation: [CONDA or PIP]

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@GabrielSoto-INL GabrielSoto-INL added the defect Something isn't working label Nov 13, 2024
@dylanjm
Copy link
Collaborator

dylanjm commented Dec 16, 2024

This issue might be addressed in #391

@j-bryan
Copy link
Collaborator

j-bryan commented Dec 16, 2024

I'll take a look and see if I can resolve this in #391 as @dylanjm is suggesting.

@j-bryan
Copy link
Collaborator

j-bryan commented Dec 24, 2024

I was taking a look at this, and it doesn't appear related to the template work in #391. The error that's thrown comes during the Case initialization before the template driver is reached. I think it would be best handled in a separate pull request.

The stack trace I get when adding an <optimization_settings> block to the LevelizedCapex test heron_input.xml file (some line numbers might not match, I ran this quickly on a branch that's not devel!):

image

@GabrielSoto-INL, is this the same type of error you were seeing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants