Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_platform: Named security groups are not unique to job runs #8

Open
syndr opened this issue May 9, 2024 · 1 comment
Open

ec2_platform: Named security groups are not unique to job runs #8

syndr opened this issue May 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@syndr
Copy link
Collaborator

syndr commented May 9, 2024

If a security group is specified by name, all job runs will match the same group based on specifically that name. This becomes an issue when there are multiple test jobs running concurrently, as the destroy step of one job will remove the security group that is being used by the other (still running) job.

Named security groups are necessary for any tests where multiple instances need to communicate with each other (any clustered application).

These groups should have a tag applied with the unique ID for the currently running Molecule job, and adds/deletes should filter based upon that value to avoid trampling on other tests.

@syndr syndr added the bug Something isn't working label May 9, 2024
@syndr
Copy link
Collaborator Author

syndr commented Oct 11, 2024

This should probably be updated to skip the delete step if the security group doesn't have a tag on it for the currently running job. Furthermore, if the security group already exists, that tag should not be added in order to prevent destruction of SGs that have relevance outside of a particular molecule job run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant