Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decide on starknet token and wallet address representations on cosmos #177

Open
rnbguy opened this issue Jan 10, 2025 · 0 comments
Open
Labels

Comments

@rnbguy
Copy link
Member

rnbguy commented Jan 10, 2025

hermes-sdk has HasAddressType and HasDenomType but they have Display bound to use to_string() whenever possible.

But in Starknet, Felt::to_string returns the u256 number, not the hex encoded string which is mostly popular.

For example,

# u256
1311825980905418834733672785961618978053106732430637247341599459637071648036
# hex formatted. in python, this is just `hex(number)`
0x2e67799f855cff9fde57903a5c8ae4e31722c170d66203717c7756f366b1524

Ideally, we should use Felt::to_fixed_hex_string (for any kind of erc20 contract address) for the conventional hex format.

@rnbguy rnbguy added the relayer label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant