Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EncodeByteArray should encode to String and not to Vec<u8> #178

Open
rnbguy opened this issue Jan 10, 2025 · 0 comments
Open

EncodeByteArray should encode to String and not to Vec<u8> #178

rnbguy opened this issue Jan 10, 2025 · 0 comments
Labels
relayer

Comments

@rnbguy
Copy link
Member

rnbguy commented Jan 10, 2025 •
edited
Loading

We have

ibc-starknet/relayer/crates/cairo-encoding-components/src/components/encode_mut.rs

Line 23 in c13b888

(ViaCairo, Vec<u8>): EncodeByteArray,

IMO, this should be

(ViaCairo, Vec<u8>): EncodeList,

to correspond with Array<u8> in Cairo.

If I understood correctly, ByteArray in Cairo (loosely) represents byte-string representation. This is already done by

ibc-starknet/relayer/crates/cairo-encoding-components/src/components/encode_mut.rs

Line 29 in c13b888

(ViaCairo, String): EncodeUtf8String,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
relayer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rnbguy