Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code: Replace Node trait with more flexible solution or remove it altogether #701

Open
Tracked by #718
romac opened this issue Dec 18, 2024 · 3 comments
Open
Tracked by #718
Labels
application Related to building applications on top of Malachite code Code/implementation related P: high Priority: high
Milestone

Comments

@romac
Copy link
Member

romac commented Dec 18, 2024

The Node trait is clunky at best right now, as it hardcodes the app configuration type, enforces the loading of the private from a file (and therefore wouldn't support something like TMKMS), and contains a useless run method that is only useful for the test CLI crate.

@romac romac changed the title code: Revisit Node trait code: Replace Node trait with more flexible solution or remove altogether Dec 18, 2024
@romac romac changed the title code: Replace Node trait with more flexible solution or remove altogether code: Replace Node trait with more flexible solution or remove it altogether Dec 18, 2024
@romac romac added this to the Phase 5 milestone Dec 18, 2024
@romac romac added application Related to building applications on top of Malachite code Code/implementation related P: high Priority: high labels Dec 18, 2024
@namn-grg
Copy link

Hi, can I take this?
whats the best way to go forward, should I remove the trait or keep a very minimal trait

@romac
Copy link
Member Author

romac commented Jan 15, 2025

Hi, thanks for the offer, but we need to reflect more on what the final solution would look like before anyone can actually work on this.

@romac
Copy link
Member Author

romac commented Jan 15, 2025

But if you have ideas, we are all ears! Feel free to discuss them here or open a PR to showcase them. I just can't provide you with a final design as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application Related to building applications on top of Malachite code Code/implementation related P: high Priority: high
Projects
None yet
Development

No branches or pull requests

2 participants