Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add standard test-and-release.yml workflow #677

Closed
mcm1957 opened this issue Jan 3, 2025 · 6 comments
Closed

Please add standard test-and-release.yml workflow #677

mcm1957 opened this issue Jan 3, 2025 · 6 comments

Comments

@mcm1957
Copy link
Contributor

mcm1957 commented Jan 3, 2025

Please add standard testing.

Although adapter start testing is not useful for an icon only (onlyWWW) adapter the standard package tests (first step within standard test-and-release workflow) should be present.

Please let us know if you need any help / suggestions and / or I should provide a PR.

@skvarel
Copy link
Member

skvarel commented Jan 3, 2025

Dear @mcm1957

Pls provide a PR

Thanks & greetings, Sven

@skvarel
Copy link
Member

skvarel commented Jan 4, 2025

@mcm1957 ... ich habe jetzt die test-and-release.yml angelegt

@mcm1957
Copy link
Contributor Author

mcm1957 commented Jan 4, 2025

Wo hast du denn diese Variante gefunden :-).

Ich schreib dir nen PR aber gib nur noch ein wenig Zeit.

@mcm1957
Copy link
Contributor Author

mcm1957 commented Jan 4, 2025

see #680

@mcm1957
Copy link
Contributor Author

mcm1957 commented Jan 4, 2025

Wenn du eine automatische NPM-Bereitstellung willst, musst du den entsprechenden Abschnitt im Workflow einkommentieren und ein NPM-Token festlegen. Da du den Workflow bisher nicht verwendet hast, habe ich diese Funktion nicht aktiviert, um das aktuelle Verhalten beizubehalten

@skvarel skvarel closed this as completed Jan 4, 2025
@skvarel
Copy link
Member

skvarel commented Jan 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants