-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for 'JPX' not declared #8
Comments
1) using maven-shade instead of maven-assembly so that META-INF/services files are merged (previously, because all the imageio libs have to use the same file name, only one was being included) 2) because the jai-imageio JPEG2000 package didn't declare support for JPX, a proxy Spi class had to be added to declare it 3) TesseractOCRParser doesn't declare support for JPEG2000 images either, even though Tesseract with Leptonica compiled with jp2 support will handle these, so an additional parser was added to handle these files Issues filed: jai-imageio/jai-imageio-jpeg2000#8 https://issues.apache.org/jira/browse/TIKA-2174
I am not so sure if the J2KWriter even supports reading or writing JPX (JPEG 2000 Part 2, ISO 15444-2).. were you able to verify that with a test resource? Would you be able to supply a pull request with a similar change as in I see you depend on this dependency - would that be needed for JPX instead of our bundled jj2000 code? <dependency>
<groupId>edu.ucar</groupId>
<artifactId>jj2000</artifactId>
<version>5.3</version>
</dependency> (It is not in Maven Central.. :-/) I think JPX could be registered a separate |
Yes, I will happily make that pull request. Would you consider using Unidata's jj2000 fork instead of the one you currently bundle? 5.3 is available on their repo. |
Yes, that could be a good option - except that it resides in the Are there license reasons why Unidata's fork can't go into Maven Central? The J2000 license is quite restrictive because of the patent clause - if I switch to using an external reference implementation I would not want to shade it inside the JAR (an easy workaround to avoid repo at runtime), as that would mean my employer could be sued for patent infringement if the fork is no longer JPEG2000 compliant! As I have not touched the If the forked implementation JAR was accessible from say Maven Central or BinTray, then I would be fairly happy with it being available in the future, and could use it just as a |
I've filed Unidata/jj2000#6 to get Unidata's fork published to Maven Central. |
The ReaderSpi and WriterSpi classes should declare support for JPX format images, otherwise these are not handled by PDFBox and in turn, Tika, for example.
It's a matter of adding 'jpx' to
formatNames
andextensions
and 'image/jpx' tomimeTypes
.The text was updated successfully, but these errors were encountered: