Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for updating assumptions / documentation #34

Open
lookingcloudy opened this issue Jun 16, 2020 · 1 comment
Open

Suggestions for updating assumptions / documentation #34

lookingcloudy opened this issue Jun 16, 2020 · 1 comment

Comments

@lookingcloudy
Copy link

The pro library seems to assume folks are using:

  • Microsoft MVC Routing
  • EF migrations
  • dbo schema

I'd like to suggest that you not make these assumptions. In our case, I had to add app.UseRouting() to get Pro working. We use fluent migrator, not EF migrations. Fortunately, I found your previous ticket where you posted the SQL Create Table statements. I was able to create migrations from this information. Also, these create statements (assuming also your EF migrations) assume the dbo schema. In our case, this particular application uses its own schema (not DBO).

@jamesmh
Copy link
Owner

jamesmh commented Jun 16, 2020

Coravel Pro originally was designed to work specifically with the built-in/ default EF core tooling.

  • Routing is necessary and I will have to update the docs to reflect this 👍
  • Again, right now, the design is targeted to ef core migrations... there are ways to figure out what columns to add to manual migrations, but can see that it may not be ideal. Will have to mull on this one as far as adding future support or not.
  • Agree that non-dbo schema would be nice, but have not had any push-back by any paying clients so far. So this would potentially be a new feature/config option in the future that will need to be prioritized.

Will keep this open for now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants