From ac6e3746ec6123ccb22e6391cbd766892974962d Mon Sep 17 00:00:00 2001 From: Jacob Bolda Date: Tue, 10 Dec 2024 00:13:17 -0600 Subject: [PATCH] bump playwright to 1.49.1 including override (#873) * bump playwright to 1.49.1 including override * try removing assertion * is nested step cursed? --- package-lock.json | 84 ++++++++++++++++++------------------ package.json | 6 +-- tests/helpers/elements.ts | 1 - tests/transactions/helper.ts | 8 ++-- 4 files changed, 48 insertions(+), 51 deletions(-) diff --git a/package-lock.json b/package-lock.json index 686a2d6b..9e0c64cd 100644 --- a/package-lock.json +++ b/package-lock.json @@ -35,8 +35,8 @@ }, "devDependencies": { "@estruyf/github-actions-reporter": "^1.9.2", - "@playwright/experimental-ct-react17": "^1.49.0", - "@playwright/test": "^1.49.0", + "@playwright/experimental-ct-react17": "^1.49.1", + "@playwright/test": "^1.49.1", "@tauri-apps/cli": "2.1.0", "@trivago/prettier-plugin-sort-imports": "^4.3.0", "@types/d3": "^7.4.3", @@ -3320,14 +3320,14 @@ } }, "node_modules/@playwright/experimental-ct-core": { - "version": "1.49.0", - "resolved": "https://registry.npmjs.org/@playwright/experimental-ct-core/-/experimental-ct-core-1.49.0.tgz", - "integrity": "sha512-Tl/JekIQOyHIctFvzmHaSB8SuBTbOYcIdrb5HMwMc70i86XbPnQfDp65zgzAuvUiDN1u1k+aIpygJ8ZqnRYgVw==", + "version": "1.49.1", + "resolved": "https://registry.npmjs.org/@playwright/experimental-ct-core/-/experimental-ct-core-1.49.1.tgz", + "integrity": "sha512-MZ0by8hLo/2qGHoo3SSbdxTNwKXrw06rqqA64TEiwOBjzpbYAaCuA3+BemXpMFfa0nU6ivO4h/sFdA8Zv9ns+g==", "dev": true, "license": "Apache-2.0", "dependencies": { - "playwright": "1.49.0", - "playwright-core": "1.49.0", + "playwright": "1.49.1", + "playwright-core": "1.49.1", "vite": "^5.2.8" }, "engines": { @@ -3335,13 +3335,13 @@ } }, "node_modules/@playwright/experimental-ct-react17": { - "version": "1.49.0", - "resolved": "https://registry.npmjs.org/@playwright/experimental-ct-react17/-/experimental-ct-react17-1.49.0.tgz", - "integrity": "sha512-9D621Y30120SbX3l2CNA57Jj4Y4xnYxx1SpqSC1qiFbWMbrr3YXrk9+fB7rHECKwQkZal47vwTt9wq8gL7u2Qg==", + "version": "1.49.1", + "resolved": "https://registry.npmjs.org/@playwright/experimental-ct-react17/-/experimental-ct-react17-1.49.1.tgz", + "integrity": "sha512-K58VIKBZ80iuMCaS39u9X8esu+zneJ74HeGVJs4AWkpQrDDNesObaTBmQfYx/aBtI/lvH5ly4nC8JfD90g8/hQ==", "dev": true, "license": "Apache-2.0", "dependencies": { - "@playwright/experimental-ct-core": "1.49.0", + "@playwright/experimental-ct-core": "1.49.1", "@vitejs/plugin-react": "^4.2.1" }, "bin": { @@ -3352,13 +3352,13 @@ } }, "node_modules/@playwright/test": { - "version": "1.49.0", - "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.49.0.tgz", - "integrity": "sha512-DMulbwQURa8rNIQrf94+jPJQ4FmOVdpE5ZppRNvWVjvhC+6sOeo28r8MgIpQRYouXRtt/FCCXU7zn20jnHR4Qw==", + "version": "1.49.1", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.49.1.tgz", + "integrity": "sha512-Ky+BVzPz8pL6PQxHqNRW1k3mIyv933LML7HktS8uik0bUXNCdPhoS/kLihiO1tMf/egaJb4IutXd7UywvXEW+g==", "dev": true, "license": "Apache-2.0", "dependencies": { - "playwright": "1.49.0" + "playwright": "1.49.1" }, "bin": { "playwright": "cli.js" @@ -9964,13 +9964,13 @@ } }, "node_modules/playwright": { - "version": "1.49.0", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.49.0.tgz", - "integrity": "sha512-eKpmys0UFDnfNb3vfsf8Vx2LEOtflgRebl0Im2eQQnYMA4Aqd+Zw8bEOB+7ZKvN76901mRnqdsiOGKxzVTbi7A==", + "version": "1.49.1", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.49.1.tgz", + "integrity": "sha512-VYL8zLoNTBxVOrJBbDuRgDWa3i+mfQgDTrL8Ah9QXZ7ax4Dsj0MSq5bYgytRnDVVe+njoKnfsYkH3HzqVj5UZA==", "dev": true, "license": "Apache-2.0", "dependencies": { - "playwright-core": "1.49.0" + "playwright-core": "1.49.1" }, "bin": { "playwright": "cli.js" @@ -9983,9 +9983,9 @@ } }, "node_modules/playwright-core": { - "version": "1.49.0", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.49.0.tgz", - "integrity": "sha512-R+3KKTQF3npy5GTiKH/T+kdhoJfJojjHESR1YEWhYuEKRVfVaxH3+4+GvXE5xyCngCxhxnykk0Vlah9v8fs3jA==", + "version": "1.49.1", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.49.1.tgz", + "integrity": "sha512-BzmpVcs4kE2CH15rWfzpjzVGhWERJfmnXmniSyKeRZUs9Ws65m+RGIi7mjJK/euCegfn3i7jvqWeWyHe9y3Vgg==", "dev": true, "license": "Apache-2.0", "bin": { @@ -14099,33 +14099,33 @@ "optional": true }, "@playwright/experimental-ct-core": { - "version": "1.49.0", - "resolved": "https://registry.npmjs.org/@playwright/experimental-ct-core/-/experimental-ct-core-1.49.0.tgz", - "integrity": "sha512-Tl/JekIQOyHIctFvzmHaSB8SuBTbOYcIdrb5HMwMc70i86XbPnQfDp65zgzAuvUiDN1u1k+aIpygJ8ZqnRYgVw==", + "version": "1.49.1", + "resolved": "https://registry.npmjs.org/@playwright/experimental-ct-core/-/experimental-ct-core-1.49.1.tgz", + "integrity": "sha512-MZ0by8hLo/2qGHoo3SSbdxTNwKXrw06rqqA64TEiwOBjzpbYAaCuA3+BemXpMFfa0nU6ivO4h/sFdA8Zv9ns+g==", "dev": true, "requires": { - "playwright": "1.49.0", - "playwright-core": "1.49.0", + "playwright": "1.49.1", + "playwright-core": "1.49.1", "vite": "^5.2.8" } }, "@playwright/experimental-ct-react17": { - "version": "1.49.0", - "resolved": "https://registry.npmjs.org/@playwright/experimental-ct-react17/-/experimental-ct-react17-1.49.0.tgz", - "integrity": "sha512-9D621Y30120SbX3l2CNA57Jj4Y4xnYxx1SpqSC1qiFbWMbrr3YXrk9+fB7rHECKwQkZal47vwTt9wq8gL7u2Qg==", + "version": "1.49.1", + "resolved": "https://registry.npmjs.org/@playwright/experimental-ct-react17/-/experimental-ct-react17-1.49.1.tgz", + "integrity": "sha512-K58VIKBZ80iuMCaS39u9X8esu+zneJ74HeGVJs4AWkpQrDDNesObaTBmQfYx/aBtI/lvH5ly4nC8JfD90g8/hQ==", "dev": true, "requires": { - "@playwright/experimental-ct-core": "1.49.0", + "@playwright/experimental-ct-core": "1.49.1", "@vitejs/plugin-react": "^4.2.1" } }, "@playwright/test": { - "version": "1.49.0", - "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.49.0.tgz", - "integrity": "sha512-DMulbwQURa8rNIQrf94+jPJQ4FmOVdpE5ZppRNvWVjvhC+6sOeo28r8MgIpQRYouXRtt/FCCXU7zn20jnHR4Qw==", + "version": "1.49.1", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.49.1.tgz", + "integrity": "sha512-Ky+BVzPz8pL6PQxHqNRW1k3mIyv933LML7HktS8uik0bUXNCdPhoS/kLihiO1tMf/egaJb4IutXd7UywvXEW+g==", "dev": true, "requires": { - "playwright": "1.49.0" + "playwright": "1.49.1" } }, "@react-aria/breadcrumbs": { @@ -18685,19 +18685,19 @@ "integrity": "sha512-saLsH7WeYYPiD25LDuLRRY/i+6HaPYr6G1OUlN39otzkSTxKnubR9RTxS3/Kk50s1g2JTgFwWQDQyplC5/SHZg==" }, "playwright": { - "version": "1.49.0", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.49.0.tgz", - "integrity": "sha512-eKpmys0UFDnfNb3vfsf8Vx2LEOtflgRebl0Im2eQQnYMA4Aqd+Zw8bEOB+7ZKvN76901mRnqdsiOGKxzVTbi7A==", + "version": "1.49.1", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.49.1.tgz", + "integrity": "sha512-VYL8zLoNTBxVOrJBbDuRgDWa3i+mfQgDTrL8Ah9QXZ7ax4Dsj0MSq5bYgytRnDVVe+njoKnfsYkH3HzqVj5UZA==", "dev": true, "requires": { "fsevents": "2.3.2", - "playwright-core": "1.49.0" + "playwright-core": "1.49.1" } }, "playwright-core": { - "version": "1.49.0", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.49.0.tgz", - "integrity": "sha512-R+3KKTQF3npy5GTiKH/T+kdhoJfJojjHESR1YEWhYuEKRVfVaxH3+4+GvXE5xyCngCxhxnykk0Vlah9v8fs3jA==", + "version": "1.49.1", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.49.1.tgz", + "integrity": "sha512-BzmpVcs4kE2CH15rWfzpjzVGhWERJfmnXmniSyKeRZUs9Ws65m+RGIi7mjJK/euCegfn3i7jvqWeWyHe9y3Vgg==", "dev": true }, "possible-typed-array-names": { diff --git a/package.json b/package.json index 7c63e5be..81c464a3 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,7 @@ "react-dom": "18.3.1" }, "@estruyf/github-actions-reporter": { - "@playwright/test": "^1.43.0" + "@playwright/test": "^1.49.1" } }, "@parcel/resolver-default": { @@ -56,8 +56,8 @@ }, "devDependencies": { "@estruyf/github-actions-reporter": "^1.9.2", - "@playwright/experimental-ct-react17": "^1.49.0", - "@playwright/test": "^1.49.0", + "@playwright/experimental-ct-react17": "^1.49.1", + "@playwright/test": "^1.49.1", "@tauri-apps/cli": "2.1.0", "@trivago/prettier-plugin-sort-imports": "^4.3.0", "@types/d3": "^7.4.3", diff --git a/tests/helpers/elements.ts b/tests/helpers/elements.ts index 963d46a3..c346bc06 100644 --- a/tests/helpers/elements.ts +++ b/tests/helpers/elements.ts @@ -25,7 +25,6 @@ export const selectOption = (page: Page, label: string, option: string) => await expect(async () => { await selectInput.scrollIntoViewIfNeeded(); await selectInput.click(); - await expect(page.getByRole('option', { name: option })).toBeInViewport(); await page.getByRole('option', { name: option }).click(); }).toPass(); }); diff --git a/tests/transactions/helper.ts b/tests/transactions/helper.ts index 91aec0b3..c32bbf49 100644 --- a/tests/transactions/helper.ts +++ b/tests/transactions/helper.ts @@ -38,11 +38,9 @@ export const addGenericTransaction = async ( }); if (extraActions) { - await test.step('Extra Actions', async () => { - for (let pageAction of extraActions) { - await pageAction; - } - }); + for (let pageAction of extraActions) { + await pageAction; + } } await page.getByLabel('value').first().fill(value);