CachingHttpContentFactory$CachedHttpContent already released buffer #12681
Assignees
Labels
Comments
|
@lorban if I remove the setting of |
|
@gregw I unfortunately cannot reproduce this locally, however the exception is thrown from Can you put a breakpoint on that catch block's |
|
@lorban I modified the method to: @Override
public void writeTo(Content.Sink sink, long offset, long length, Callback callback)
{
try
{
_buffer.retain();
sink.write(true, BufferUtil.slice(_buffer.getByteBuffer(), (int)offset, (int)length), Callback.from(_buffer::release, callback));
}
catch (Throwable x)
{
// BufferUtil.slice() may fail if offset and/or length are out of bounds.
try
{
_buffer.release();
}
catch (Throwable x2)
{
x2.addSuppressed(x);
throw x2;
}
callback.failed(x);
}
}and now it reports: So the buffer has already been released, but not nulled? |
|
The release is happening from: |
|
@lorban the issue is that the content is being released from the cache in the shrink, immediately after it has been added and before it has been used. |
|
@lorban the model for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version(s)
12.1.x
Jetty Environment
EE11
Description
Whilst developing PR #12678, I have woken up
org.eclipse.jetty.servlet6.embedded.Http2Servereven though there is noPushCacheFilteranymore. The intention is to convert it to early hints instead.However, whilst running the draft Http2Server, I often get exceptions like below when serving the tiles:
How to reproduce?
run the
Http2Serverclass, hit http://localhost:8080, do shift reload a few timesThe text was updated successfully, but these errors were encountered: