-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncoid Dry Run Options #11
Labels
Comments
i'd like to see this, too! :) |
hi, |
hey guys, is this thing difficult to implement? |
this would be great to have. |
Closed
anarcat
added a commit
to anarcat/sanoid
that referenced
this issue
May 30, 2022
This is a little messy: that includes a *lot* of whitespace change, but I couldn't really figure out a better way to do it, in general. (A better way would have been something like: if ($args{'dryrun'}) return 0; ... but the functions are generally too long for that kind of hack to work at all. Alternatively, I figured it might be good to have a generic `system()` wrapper, but I haven't dug deep enough in the code to see if it's always called the same way, or if that would make sense.) This doesn't block *all* `system()` calls either: only those who actually make changes. SSH setup commands and commands that just probe the snapshot lists are let through, so this is not completely a `--noop` flag (hence the `--dryrun` instead), because it actually *does* some things still. I have only grepped for `system()` and haven't audited the entire source code to see if other side effects (e.g. creating files) also exist. Disclaimer: this patch was briefly tested on my home system, and my level of familiarity with sanoid is "beginner". Closes: jimsalterjrs#11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I want to see that my configuration is correct, or see what syncoid will do before I do it. A dry run option would be nice.
The text was updated successfully, but these errors were encountered: