Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data format for conversion_feature and null_feature #9

Open
jayden199012 opened this issue Feb 10, 2020 · 0 comments
Open

Data format for conversion_feature and null_feature #9

jayden199012 opened this issue Feb 10, 2020 · 0 comments

Comments

@jayden199012
Copy link

jayden199012 commented Feb 10, 2020

When I read your note in markov.py. For feature conversion_feature and null_feature, you have specifically mentioned that

do not pre-aggregate conversions by path as this will effect the outcome of the simulation.

Does this means that the data format for these two features can only be 0 or 1?

I noticed that your implementation is very similar to the original ChannelAttribution R package, but the original R package allows aggregated values (sum) by str_path for these two features. I wonder is there a difference in implementation that resulting the different data requirement?

Thank you in advance for helping me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant