Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

greenwich misplotted in the US (near chicago) for 'prince'? #1

Closed
jgravois opened this issue Dec 30, 2015 · 6 comments
Closed

greenwich misplotted in the US (near chicago) for 'prince'? #1

jgravois opened this issue Dec 30, 2015 · 6 comments
Assignees
Labels

Comments

@jgravois
Copy link

very cool project!

i'm not positive exactly what's going on, but something looks odd when comparing the top few results in the chart and map when you search for and plot 'prince' shows on the globe.

prince
looking at the map, chart and JSON, my best guess is that shows in greenwich are being plotted somewhere near Chicago, even though the lat/long in the payload are accurate

venue: {
  // ...
  city: "Greenwich",
  latitude: 51.4666667,
  longitude: 0
}
@jtpio
Copy link
Owner

jtpio commented Dec 31, 2015

Good catch!
As you mentioned, the data retrieved from the Bandsintown API looks correct.
So it might be an issue with the WebGL Globe itself.

A quick search brought me to this: dataarts/webgl-globe#29

I will have a closer look in a few days, but if you find something in the meantime, please let me know.

@jgravois
Copy link
Author

given that the rest of your data is plotting correctly, perhaps the falsy longitude of 0 is problematic downstream?

@jtpio
Copy link
Owner

jtpio commented Jan 3, 2016

Yes good point. Should be reproducible.

@jtpio jtpio added the bug label Jan 7, 2016
@jtpio jtpio self-assigned this Jan 7, 2016
@jtpio
Copy link
Owner

jtpio commented Jan 7, 2016

I found the bug.
Cities were grouped by venue name, which corresponds to the city name alone. It turns out that there is a city called London in Canada as well as the one in the UK. That's why the data from London (UK) was plotted next to Chicago.

Fixed by 3a70a1b.

@jtpio jtpio closed this as completed Jan 7, 2016
@jgravois
Copy link
Author

jgravois commented Jan 7, 2016

nice work. thanks for humoring me!

@jtpio
Copy link
Owner

jtpio commented Jan 7, 2016

Thank you for spotting this tricky bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants