You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not really a justpy issue, but use of that example could be slightly confusing.
In the ag-Grid Guide, Grid Events, Example 3 there is an issue with deselection events.
Since the index returned from the grid is really NOT an index, but, a visible index (rowIndex), the example can get lost when there are invisible selected rows.
To see the issue:
select Toyota
Use the ag filter on Make and type in 'Ford'
With only the Ford row visible select it
So far so good
Deselect Ford
See that the wrong row is removed.
The removal code much match the incoming deselection event row with the selected_rows data. The index is unreliable.
{I suppose since there is no unique guarantee on the index, the entire data row should be matched, but some grids might have multiple matching rows (all the data).} Granted this is a fringe case and inadvisable in terms of setup, but it is possible, clearly.
Interaction between ag-Grid and anything, justpy in this case, has to account for the oddity of (visible) rowIndex versus (actual) selected row index.
This discussion was converted from issue #347 on February 02, 2022 20:27.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Not really a justpy issue, but use of that example could be slightly confusing.
In the ag-Grid Guide, Grid Events, Example 3 there is an issue with deselection events.
Since the index returned from the grid is really NOT an index, but, a visible index (rowIndex), the example can get lost when there are invisible selected rows.
To see the issue:
So far so good
See that the wrong row is removed.
The removal code much match the incoming deselection event row with the selected_rows data. The index is unreliable.
{I suppose since there is no unique guarantee on the index, the entire data row should be matched, but some grids might have multiple matching rows (all the data).} Granted this is a fringe case and inadvisable in terms of setup, but it is possible, clearly.
Interaction between ag-Grid and anything, justpy in this case, has to account for the oddity of (visible) rowIndex versus (actual) selected row index.
Beta Was this translation helpful? Give feedback.
All reactions