Replace add_resize_listener with add_iframe_resize_listener #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated by running npm install
- Starting 3.59.x, add_resize_listener got renamed tto add_iframe_resize_listener
nasvillanueva
changed the title
|
Closing this PR. We stopped using svelte a few months ago, and I don't think this is ever getting any action (probably outdated too!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, from 3.59.0, one of the internal svelte function got renamed so it broke some tests that are using it. Our project isn't using it directly, but with
svelte-htm.The function seems to be exactly the same. Just renamed.
sveltejs/svelte@cfe26d8/src/runtime/internal/dom.ts#L692
sveltejs/svelte@4537eb7/src/runtime/internal/dom.ts#L702
Fixes #223