Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] GNOME 46 Support #276

Open
InklingGirl opened this issue Apr 11, 2024 · 25 comments
Open

[FEATURE] GNOME 46 Support #276

InklingGirl opened this issue Apr 11, 2024 · 25 comments
Assignees

Comments

@InklingGirl
Copy link

The latest LTS version of Ubuntu is launching w/ GNOME 46 this month, so it would be great to have this extension up-to-date on https://extensions.gnome.org/extension/906! It's really indispensable for the UX of my system, thank you.

@InklingGirl
Copy link
Author

or for the love of god somebody please fork it, lol

@InklingGirl
Copy link
Author

new versions of ubuntu & fedora have launched w/ gnome 46

@InklingGirl
Copy link
Author

:(

@sgrzy01
Copy link

sgrzy01 commented May 30, 2024

I hear you... I wish I could help... I listen to music all day every day while I work, and this extension is a big part of my day...

@harrissondutra
Copy link

Please!! give us a version for GNOME 46!!

@FoamyGuy
Copy link

FoamyGuy commented Jul 9, 2024

peopleHopingForUpdatedVersion++

In #263 the changes to support gnome 43 were fairly minimal... I have no prior experience with gnome extension development but do wonder if it's possible that just adding 46 to the list in the config file is all that is necessary.

Or whether there are likely to be more substantial changes required.

@InklingGirl
Copy link
Author

Unfortunately @FoamyGuy, in terms of visual layout at least, the top-right dropdown menu from the GNOME top bar this extension deals w/ is substantially different than previous versions' implementations, so the porting of this extension will likely be a little bit more involved than just changing a version number in a .json file. I could try, but I highly doubt it'll work at all. Unfortunately, I'm not a developer either.

@TheBlackKoala
Copy link

So i am a developer (though not familiar with javascript) and i've had a quick look. From what i can tell the biggest change is that from gnome 45 the old import system has been deprecated so i'll look into updating the imports and see if everything works. Not sure how much time i will have to dedicate to this but if i get something that works or is close to i will update in here

@InklingGirl
Copy link
Author

Thank you @TheBlackKoala, you're a saint.

@TheBlackKoala
Copy link

So a short update in my progress: It looks like a lot more changed with gnome 45 than i had anticipated so i'll probably have to remake this extension from the ground up. This is gonna take some serious time.

@InklingGirl
Copy link
Author

So I suspected.

@kgshank
Copy link
Owner

kgshank commented Oct 4, 2024

So a short update in my progress: It looks like a lot more changed with gnome 45 than i had anticipated so i'll probably have to remake this extension from the ground up. This is gonna take some serious time.

Yes, there are lots of changes in the Gnome side and the extension is also bloated in my opinion. I started from scratch with some new ideas to make it easier for maintenance, but couldn't dedicate enough time now.

@TheBlackKoala
Copy link

@kgshank would you mind sharing your progress? That could probably give me a bit of a kickstart

@kgshank
Copy link
Owner

kgshank commented Oct 9, 2024

@TheBlackKoala I have committed my changes to branch wip

Not much changes here. My idea was to create a new volume indicator as a subclass of the original Gnome sound indicator and add additional custom changes there. I also planned to reduce the number of options and then add one by one, if there is demand.

@TheBlackKoala
Copy link

So i've looked into it but i'm gonna have to throw in the towel - as far as i can see gnome now has an output choice by default (or maybe an extension i've installed?) so i'm gonna accept that as the new thing.
Yeah sorry but i'm not a javascript person and making this extension work post gnome 45 is gonna be a serious task to undertake.

@ba32107
Copy link

ba32107 commented Oct 15, 2024

Can you show us what you mean by the default output choice? A screenshot would be great. I don't see anything similar

@TheBlackKoala
Copy link

Så i have an arrow for the sound output and when i press it i get this view:
Screenshot from 2024-10-15 11-55-57

@ba32107
Copy link

ba32107 commented Oct 15, 2024

Oh - this looks great and it's exactly what this extension is about. I'm not at my machine now, but I'm pretty sure I don't have this.

Would you mind checking if you have any other extensions installed that could have possibly added this feature?

@FoamyGuy
Copy link

FoamyGuy commented Oct 15, 2024

OMG! Thank you for that screenshot and description of how to access it @TheBlackKoala.

I had never noticed the icon that reveals the rest of the chooser before. That does indeed seem to be the new default behavior. I do not believe that I have any plugin installed that could be responsible for that.

Accessing the sound output from within that "dropdown reveal thing" is more convenient than going all the way to the sound settings.

But it would still be a bit more convenient if the list were just always showing and you didn't need to click the arrow icon to reveal it, which is more like how I remember this plugin working (though it's been few months since I used it by now my memory could be off). I wonder if it would be easier to modify the new stock panel to automatically always show that sound chooser "pop out" section by default instead of needing the user to press the icon to reveal it.

@TheBlackKoala
Copy link

@ba32107 these and Pamac Updates indicator are all the extensions i have enabled on my system.
Screenshot from 2024-10-15 15-59-55

@ba32107
Copy link

ba32107 commented Oct 15, 2024

It seems I was wrong, just got home and checked, and I have the same thing! The functionality is there, and I've never realised it. Thanks so much @TheBlackKoala

@InklingGirl
Copy link
Author

If indeed the extension's functionality has been natively replicated in newer versions of GNOME, shall I close this issue?

@TheBlackKoala
Copy link

I don't know if i'd say that the full functionality has been replicated the most used definitely has - i'd keep the issue but maybe link it with the gnome 45 one?

@martinkg
Copy link

@InklingGirl
can't get it working on Fedora 41 with Gnome 46 see
Bugreport

@BacLuc
Copy link

BacLuc commented Nov 23, 2024

I have the following error in the gnome extensions panel (ubuntu 24, gnome 46):

SyntaxError: import declarations may only appear at top level of a module @ resource:///org/gnome/Shell/Extensions/js/misc/extensionUtils.js:4:0

Stack trace:
  @file:///home/lucius/.local/share/gnome-shell/extensions/[email protected]/prefs.js:21:24
  _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants