Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope.Close() in AsyncAfter #7

Open
juliangruber opened this issue Nov 8, 2012 · 2 comments
Open

scope.Close() in AsyncAfter #7

juliangruber opened this issue Nov 8, 2012 · 2 comments

Comments

@juliangruber
Copy link

shouldn't we close the scope in AsyncAfter since we also opened one?

@juliangruber
Copy link
Author

scope.Close(Undefined());

@paulharris
Copy link

I assume you mean
return scope.Close(Undefined());

I don't think you need to call scope.Close() unless you want to 'rescue' a handle from destruction from the HandleScope.

In this case, I don't see why you would need to rescue the Undefined handle, it should just be

return Undefined();

// and let scope to clean up whatever handles it likes
the undefined handle won't be cleaned up like other handles, as far as I know.... right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants