Upgrade Kubernetes to v1.30.7 #2463

Electronic-Waste · 2024-12-09T09:13:57Z

What this PR does / why we need it:

Kubernetes upgrade to v1.30.7
controller-runtime upgrade to v0.18.5
Adapt controllers to use controller-runtime generics API
Adapt code generation to new kube_codegen.sh script

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2457

Checklist:

Docs included if any changes are user facing

Signed-off-by: Electronic-Waste <[email protected]>

…all. Signed-off-by: Electronic-Waste <[email protected]>

Signed-off-by: Electronic-Waste <[email protected]>

google-oss-prow · 2024-12-09T09:14:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Electronic-Waste <[email protected]>

Electronic-Waste · 2024-12-09T13:54:38Z

/rerun-all

Electronic-Waste · 2024-12-10T04:34:04Z

PTAL if you have time👀 @kubeflow/wg-automl-leads

andreyvelich

Thank you for this @Electronic-Waste!
I left my initial comments.
/assign @kubeflow/wg-training-leads @helenxie-bit

andreyvelich · 2024-12-10T17:40:35Z

.github/workflows/e2e-test-darts-cifar10.yaml

@@ -33,6 +33,6 @@ jobs:
    strategy:
      fail-fast: false
      matrix:
-        kubernetes-version: ["v1.27.11", "v1.28.7", "v1.29.2"]
+        kubernetes-version: ["v1.28.7", "v1.29.2", "v1.30.7"]


Do you want to migrate to k8s 1.31 in the followup PR ?

Yeah, I'd like to. But I'm busy this week. If it's not urgent, I'll raise another PR to migrate to k8s 1.31 next week.

I think that step by step upgrading would be better so that we can easily pick the commit when we find the issue on the specific K8s version.

So, I would recommend upgrading 1 K8s version in 1 PR.

go.mod

hack/update-openapigen.sh

andreyvelich · 2024-12-10T17:56:29Z

hack/violation_exception_v1beta1.list

@@ -0,0 +1,39 @@
+API rule violation: list_type_missing,github.com/kubeflow/katib/pkg/apis/controller/common/v1beta1,AlgorithmSpec,AlgorithmSettings


Do we need to track in a issue to resolve these violations similar to Training: kubeflow/training-operator#2317

Yeah, I'll create an issue describing this after this PR get merged.

Signed-off-by: Electronic-Waste <[email protected]>

pkg/client/controller/applyconfiguration/common/v1beta1/algorithmsetting.go

helenxie-bit · 2024-12-11T07:06:41Z

Thank you for the contribution! LGTM 🎉

Signed-off-by: Electronic-Waste <[email protected]>

tenzen-y · 2024-12-11T08:56:08Z

go.mod

+	k8s.io/apimachinery v0.30.7
+	k8s.io/client-go v0.30.7
+	k8s.io/code-generator v0.30.7
+	k8s.io/klog/v2 v2.130.1


Reverting klog version, then create dedicated issue for the klog version updating.

Signed-off-by: Electronic-Waste <[email protected]>

terrytangyuan · 2024-12-16T03:11:41Z

.github/workflows/e2e-test-darts-cifar10.yaml

@@ -33,6 +33,6 @@ jobs:
    strategy:
      fail-fast: false
      matrix:
-        kubernetes-version: ["v1.27.11", "v1.28.7", "v1.29.2"]
+        kubernetes-version: ["v1.28.7", "v1.29.2", "v1.30.7"]


We can also add one that tests whatever is the cutting edge version so we can get notified of any incompatibility earlier

SGTM. The newest version of k8s is 1.32.0 now. WDYT👀 @kubeflow/wg-automl-leads

Sorry for the late response. We upgrade the Kube version step by step.
So, I think that it would be great to use the 1.32 in separate issue.

I believe that @shaowei-su can open a PR to update Kube to 1.31 after this PR.
Then you can open PR to support 4th supporting Kube version, which meant that we support 1.29, 1.30, 1.31, 1.32 versions the same as training-operator.

Yes, we discussed it today during the call.
Let's initially support 1.28 - 1.31 in Katib 0.18 as we discussed here: #2457.
In the future, we can migrate to k8s 1.32.

SGTM. Can we work on this PR and merge it as soon as possible? The deadline for Kubeflow 1.10 feature freeze is Jan 20th. We may need to reserve some time for 1.31 version:)

Electronic-Waste · 2025-01-09T04:05:44Z

/rerun-all

Signed-off-by: Electronic-Waste <[email protected]>

andreyvelich

Thank you for this @Electronic-Waste
Overall lgtm.
/assign @tenzen-y @helenxie-bit @kubeflow/wg-training-leads

andreyvelich · 2025-01-09T14:21:52Z

Makefile

@@ -82,7 +82,7 @@ sync-go-mod:
 CONTROLLER_GEN = $(shell pwd)/bin/controller-gen
 .PHONY: controller-gen
 controller-gen:
-	@GOBIN=$(shell pwd)/bin GO111MODULE=on go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0
+	@GOBIN=$(shell pwd)/bin GO111MODULE=on go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.16.5

 # Run this if you update any existing controller APIs.
 # 1. Generate deepcopy, clientset, listers, informers for the APIs (hack/update-codegen.sh)


Please can we add the go-mod-download instruction to make generate similar to Training: https://github.com/kubeflow/training-operator/blob/master/Makefile#L50.

Got it! I will add it later.

Signed-off-by: Electronic-Waste <[email protected]>

Electronic-Waste added 9 commits December 8, 2024 11:36

chore: update go.mod & go mod tidy.

f81a1a2

Signed-off-by: Electronic-Waste <[email protected]>

chore: replace source.Kind and EnqueueRequestForXxx with typed func c…

b608ee0

…all. Signed-off-by: Electronic-Waste <[email protected]>

chore: update admission.Decoder in webhook.

bc49242

Signed-off-by: Electronic-Waste <[email protected]>

chore: update Makefile.

dc3625c

Signed-off-by: Electronic-Waste <[email protected]>

fix: update codegen script.

0a83183

Signed-off-by: Electronic-Waste <[email protected]>

chore: execute update-codegen.sh.

538cec6

Signed-off-by: Electronic-Waste <[email protected]>

chore: update openapigen & generate new openapi definitions.

11e577e

Signed-off-by: Electronic-Waste <[email protected]>

fix: fix typo error.

ed01b40

Signed-off-by: Electronic-Waste <[email protected]>

chore: update k8s version in CI.

b915471

Signed-off-by: Electronic-Waste <[email protected]>

google-oss-prow bot added the size/XXL label Dec 9, 2024

google-oss-prow bot requested review from anencore94, gaocegege and tenzen-y December 9, 2024 09:14

Electronic-Waste added 2 commits December 9, 2024 09:22

test(codegen): output CODEGEN_PKG.

146148c

Signed-off-by: Electronic-Waste <[email protected]>

fix(codegen): move shell check annotation.

5c48e4b

Signed-off-by: Electronic-Waste <[email protected]>

Electronic-Waste force-pushed the feat/upgrade-k8s-130 branch from a5755f0 to a874874 Compare December 9, 2024 11:57

fix(ci): change k8s version in go test to 1.30.0.

532ab00

Signed-off-by: Electronic-Waste <[email protected]>

Electronic-Waste force-pushed the feat/upgrade-k8s-130 branch from a874874 to 532ab00 Compare December 9, 2024 12:03

Electronic-Waste marked this pull request as draft December 9, 2024 12:48

google-oss-prow bot added the do-not-merge/work-in-progress label Dec 9, 2024

Electronic-Waste force-pushed the feat/upgrade-k8s-130 branch from 3f0e661 to 532ab00 Compare December 9, 2024 15:23

Electronic-Waste marked this pull request as ready for review December 9, 2024 15:23

google-oss-prow bot removed the do-not-merge/work-in-progress label Dec 9, 2024

google-oss-prow bot requested a review from andreyvelich December 9, 2024 15:24

andreyvelich reviewed Dec 10, 2024

View reviewed changes

Electronic-Waste added 2 commits December 11, 2024 02:56

fix: remove toolchain declaration in go.mod

8c2a15c

Signed-off-by: Electronic-Waste <[email protected]>

fix: remove codegen dependency in openapigen.sh.

f3088b2

Signed-off-by: Electronic-Waste <[email protected]>

helenxie-bit reviewed Dec 11, 2024

View reviewed changes

pkg/client/controller/applyconfiguration/common/v1beta1/algorithmsetting.go Outdated Show resolved Hide resolved

Electronic-Waste added 2 commits December 11, 2024 07:57

fix: fix bugs in recursive dir detection.

a63e300

Signed-off-by: Electronic-Waste <[email protected]>

fix: remove a blank line.

aa9c300

Signed-off-by: Electronic-Waste <[email protected]>

Electronic-Waste requested a review from andreyvelich December 11, 2024 08:17

tenzen-y reviewed Dec 11, 2024

View reviewed changes

fix: remove klog/v2

000729d

Signed-off-by: Electronic-Waste <[email protected]>

Electronic-Waste requested a review from tenzen-y December 11, 2024 10:57

terrytangyuan reviewed Dec 16, 2024

View reviewed changes

This was referenced Jan 7, 2025

[Kubeflow 1.10] Create Dependencies version list kubeflow/community#767

Open

Upgrade klog to v2 #2469

Open

Upgrade klog to v2 #2470

Open

Electronic-Waste added 2 commits January 9, 2025 05:52

chore(codegen): add three dots in the comment.

251c6f9

Signed-off-by: Electronic-Waste <[email protected]>

fix(codegen): fix package dependency on k8s.io/code-generator.

0de551d

Signed-off-by: Electronic-Waste <[email protected]>

andreyvelich reviewed Jan 9, 2025

View reviewed changes

chore(Makefile): add go-mod-download.

01e41d4

Signed-off-by: Electronic-Waste <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Kubernetes to v1.30.7 #2463

Upgrade Kubernetes to v1.30.7 #2463

Electronic-Waste commented Dec 9, 2024 •

edited

Loading

google-oss-prow bot commented Dec 9, 2024

Electronic-Waste commented Dec 9, 2024

Electronic-Waste commented Dec 10, 2024

andreyvelich left a comment

andreyvelich Dec 10, 2024

Electronic-Waste Dec 11, 2024

tenzen-y Dec 11, 2024

andreyvelich Dec 10, 2024

Electronic-Waste Dec 11, 2024

helenxie-bit commented Dec 11, 2024

tenzen-y Dec 11, 2024

Electronic-Waste Dec 11, 2024

terrytangyuan Dec 16, 2024

Electronic-Waste Dec 16, 2024 •

edited

Loading

tenzen-y Jan 8, 2025

andreyvelich Jan 8, 2025

Electronic-Waste Jan 9, 2025

Electronic-Waste commented Jan 9, 2025

andreyvelich left a comment •

edited

Loading

andreyvelich Jan 9, 2025

Electronic-Waste Jan 9, 2025

		@@ -0,0 +1,39 @@
		API rule violation: list_type_missing,github.com/kubeflow/katib/pkg/apis/controller/common/v1beta1,AlgorithmSpec,AlgorithmSettings

Upgrade Kubernetes to v1.30.7 #2463

Are you sure you want to change the base?

Upgrade Kubernetes to v1.30.7 #2463

Conversation

Electronic-Waste commented Dec 9, 2024 • edited Loading

google-oss-prow bot commented Dec 9, 2024

Electronic-Waste commented Dec 9, 2024

Electronic-Waste commented Dec 10, 2024

andreyvelich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

helenxie-bit commented Dec 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Electronic-Waste Dec 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Electronic-Waste commented Jan 9, 2025

andreyvelich left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Electronic-Waste commented Dec 9, 2024 •

edited

Loading

Electronic-Waste Dec 16, 2024 •

edited

Loading

andreyvelich left a comment •

edited

Loading