From d3aa8370aaf0b00998cc75e9bde1d81cd8806177 Mon Sep 17 00:00:00 2001 From: Chen Sun Date: Mon, 9 Sep 2024 12:26:20 -0700 Subject: [PATCH] chore: update kfp-kubernetes release scripts and instructions (#11191) Signed-off-by: Chen Sun --- kubernetes_platform/python/RELEASE.md | 3 +-- kubernetes_platform/python/create_release_branch.sh | 10 ++++++++-- kubernetes_platform/python/release.sh | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/kubernetes_platform/python/RELEASE.md b/kubernetes_platform/python/RELEASE.md index 4088da0eed3..82bac8f426e 100644 --- a/kubernetes_platform/python/RELEASE.md +++ b/kubernetes_platform/python/RELEASE.md @@ -21,8 +21,7 @@ Some steps require elevated permissions to push branches, publish the package, a Follow the instructions printed out by the script in Step 2, which explain how to push the branch to upstream. By the end, you - should have pushed a modified `__init__.py`, `conf.py`, `.gitignore`, and - two modified `.readthedocs.yml` files to the release branch. + should have pushed a modified `__init__.py`, `conf.py` (from Step 1), and `.gitignore`, `kubernetes_executor_config_pb2.py` and two modified `.readthedocs.yml` files (from Step 2) to the release branch. 4. [Requires credentials] Go to [readthedocs.org/projects/kfp-kubernetes/](https://readthedocs.org/projects/kfp-kubernetes/), diff --git a/kubernetes_platform/python/create_release_branch.sh b/kubernetes_platform/python/create_release_branch.sh index bf48c5447ef..710050b0564 100644 --- a/kubernetes_platform/python/create_release_branch.sh +++ b/kubernetes_platform/python/create_release_branch.sh @@ -48,6 +48,12 @@ else mv $PKG_ROOT/docs/.readthedocs.yml $REPO_ROOT/.readthedocs.yml rm $REPO_ROOT/kubernetes_platform/.gitignore - - echo "\nNext steps:\n\tPush branch using 'git push --set-upstream upstream $BRANCH_NAME'" + git add $PKG_ROOT/docs/.readthedocs.yml + git add $REPO_ROOT/.readthedocs.yml + git add $REPO_ROOT/kubernetes_platform/.gitignore + git add $REPO_ROOT/*_pb2.py + + echo "Next steps:" + echo "1. Inspect and commit the modified files." + echo "2. Push branch using 'git push --set-upstream upstream $BRANCH_NAME'" fi diff --git a/kubernetes_platform/python/release.sh b/kubernetes_platform/python/release.sh index e835e441d45..415751a28fa 100644 --- a/kubernetes_platform/python/release.sh +++ b/kubernetes_platform/python/release.sh @@ -43,7 +43,7 @@ else echo "Created package." echo "Testing install" - pip install $TARGET_TAR_FILE + pip install $TARGET_TAR_FILE --break-system-packages INSTALLED_VERSION=$(pip list | grep kfp-kubernetes | awk '{print $2}') if [[ "$INSTALLED_VERSION" != "$KFP_KUBERNETES_VERSION" ]] then