Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tutorials link to java microservice example #49325

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Remove tutorials link to java microservice example #49325

merged 1 commit into from
Jan 9, 2025
+0 −1

Conversation

stmcginnis
Copy link
Contributor

Description

This content was removed by an earlier PR (#48776), but not cleaned up from the tutorials index.

Follow up needed for other languages, and Java tutorial source files still need to be removed for KO and HI translations.

Issue

Closes: #49324

@stmcginnis
Remove tutorials link to java microservice example
fb8573c 
This content was removed by an earlier PR, but not cleaned up from the
tutorials index.

Signed-off-by: Sean McGinnis <[email protected]>
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 7, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 7, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 7, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fb8573c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/677d4d62b60a9d0008fba321
😎 Deploy Preview https://deploy-preview-49325--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kundan2707
kundan2707 reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing "Configuring a Java Microservice" with "Configuring Redis Using a ConfigMap" seems not a good idea as both are different. We should put some similar kind of operation

@reylejano
Copy link
Member

reylejano commented Jan 7, 2025 •
edited
Loading

Hmm, we still have this in the 1.28 docs.
https://v1-28.docs.kubernetes.io/docs/tutorials/configuration/configure-java-microservice/configure-java-microservice/
I'll look to see why it was removed or if it was moved

sftim
sftim reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5086e675170fd0c60d53ff07662f9572190e0666

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@sftim
Copy link
Contributor

sftim commented Jan 9, 2025 •
edited
Loading

@reylejano we removed the tutorial as, my opinion, it wasn't helping readers as much as we might have liked it to.

Also, Katacoda has shut down and we have not found resources to deploy a replacement.

@k8s-ci-robot k8s-ci-robot merged commit b4698de into kubernetes:main Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kundan2707 kundan2707 kundan2707 left review comments

@sftim sftim sftim left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@Princesso Princesso Awaiting requested review from Princesso

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with k8s.io/docs/tutorials/
5 participants
@stmcginnis @reylejano @k8s-ci-robot @sftim @kundan2707