Conversation
test_installation.sh installs torch unpinned, so a fresh PyPI release (2.14.1) lands in the test env while the wheel only ships PG builds for EP_TORCH_VERSIONS (up to 2.14.0). mooncake.pg then looks for mooncake.pg_2_14_1, and all six test_pg_* modules fail at import on every PR (#4439). The wheel is already installed at that point, so enumerate the mooncake.pg_* modules it ships and install the newest matching torch. Wheels without PG builds (non-cuda) keep the previous unpinned behavior. Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
12 of 14 tasks
Collaborator
Author
|
Status update: the end-to-end validation the description was waiting for is in. Both test-wheel-ubuntu legs pass on this PR (py312 in 20m58s, py310 in 6m22s), while the same job fails on every other open PR with Since this unblocks CI for the whole open queue, a review when someone has a moment would help. @Aionw you merged most of the recent CI fixes, maybe you have context on this one. |
13 of 32 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4439.
The wheel test legs of CI are red on every PR right now.
scripts/test_installation.shinstalls torch unpinned, so PyPI's latest (2.14.1) lands in the test venv, while the wheel only ships PG builds forEP_TORCH_VERSIONS(currently up to 2.14.0).mooncake.pgthen looks formooncake.pg_2_14_1, and all sixtest_pg_*modules fail at import.The wheel is already installed a few lines earlier in the same script, so it now enumerates the
mooncake.pg_*modules the wheel ships and installs the newest matching torch. Wheels without PG builds (non-cuda variants, or any detection failure) keep the previous unpinned behavior, so the change cannot make a green run worse.Module
Type of Change
How Has This Been Tested?
Test commands:
Test results:
torch==2.14.0, the newest shipped variantpip install torch numpy|| truekeepsset -eintact, same fallbacktest-wheel-ubuntulegs, which should go green againChecklist
bash -n; no pre-commit hook covers it)AI Assistance Disclosure
Kimi Code drafted the change; verification steps above were actually run as described, and the submitter has reviewed every changed line.