Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline statement wrong lineno #110

Open
laike9m opened this issue Apr 24, 2021 · 4 comments
Open

Multiline statement wrong lineno #110

laike9m opened this issue Apr 24, 2021 · 4 comments
Labels
bug Something isn't working p1

Comments

@laike9m
Copy link
Owner

laike9m commented Apr 24, 2021

image

ordinal should be on line 17 not 29, gifts should be on line 32 not 44.

@laike9m laike9m added bug Something isn't working p1 labels Apr 24, 2021
@laike9m laike9m added the good-first-issue Issues that are good for first time contributors label May 8, 2021
@laike9m
Copy link
Owner Author

laike9m commented May 8, 2021

This issue shouldn't be too hard to fix. We need to modify the map_bytecode_offset_to_lineno function. We can either record a start and end lineno, or use a range to represent lineno.

@laike9m laike9m removed the good-first-issue Issues that are good for first time contributors label May 12, 2021
@laike9m
Copy link
Owner Author

laike9m commented Jun 20, 2021

For the specific case above, the lineno is correct for Python 3.8 and 3.9.

@victorjzsun
Copy link
Collaborator

Linenos are correct for 3.8+ and changes have been made to fix some scenarios in 3.7 in #132

@laike9m
Copy link
Owner Author

laike9m commented Jan 3, 2022

Can we conclude this bug as fixed? If not, what are the cases left to be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1
Projects
None yet
Development

No branches or pull requests

2 participants