Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tracer.events assertions to golden files #125

Open
laike9m opened this issue May 12, 2021 · 3 comments
Open

Move tracer.events assertions to golden files #125

laike9m opened this issue May 12, 2021 · 3 comments
Labels
good-first-issue Issues that are good for first time contributors internal cleanup p0

Comments

@laike9m
Copy link
Owner

laike9m commented May 12, 2021

So that we don't need to manually modify them each time something is changed.
@victorjzsun victorjzsun mentioned this issue Aug 26, 2021
Merged
@laike9m laike9m added the good-first-issue Issues that are good for first time contributors label Aug 27, 2021
@laike9m
Copy link
Owner Author

laike9m commented Oct 10, 2021

Since every test method has a check_golden_file, is it possible to remove it from the method definition and enable it by default?

laike9m added a commit that referenced this issue Oct 12, 2021
@laike9m
Removed the change_lineno script, #125
018ecbb
@victorjzsun
Copy link
Collaborator

Since every test method has a check_golden_file, is it possible to remove it from the method definition and enable it by default?

No, test_import and other files with assert_that do not use check_golden_file due to system naming

@laike9m
Copy link
Owner Author

laike9m commented Oct 12, 2021

Then we probably should change the test file's name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Issues that are good for first time contributors internal cleanup p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laike9m @victorjzsun