Laravel request handling inconsistencies

[macropay-solutions]

We know that laravel community says $request->input( should be used instead of $request->get(

The get returns results from the route params if exists and if not, only then goes to query and then to request InputBag.
The input returns from input source + query params, input source being only json or query or request InputBag.

The offsetUnset removes the key only from the InputBag that the input function uses. This leads to unpredictable results when you send a PUT request as json and also put query string in the url.

Same is valid for replace function.

To fix these we had to create 2 macros: https://github.com/macropay-solutions/laravel-crud-wizard-free/blob/39035ec6e4066a3f051455c061b861d4b592c345/src/Providers/CrudProvider.php#L42

UPDATE: we updated the macros.

NOTE:
$request->all() returns from InputBag (which is json or query or request) + query + files.

We write this here as FYI.

[shaedrich]

Furthermore, $request->safe() returns $this->validator->safe() when it's a FormRequest. Sure, we want the input to be validated, but this can lead to different return values, while we would rather want to get an exception, not get a misleading value without any heads-up.

[macropay-solutions]

We updated the macros. The forceReplace was not ok in its first version.
Updated again for x-www-form-urlencoded. The multipart/form-data seems not to work with PUT but seems to be a known behaviour https://stackoverflow.com/questions/47676134/laravel-request-all-is-empty-using-multipart-form-data

[macropay-solutions]

@shaedrich The only difference to validated is the return type.

    /**
     * Get a validated input container for the validated input.
     *
     * @param  array|null  $keys
     * @return \Illuminate\Support\ValidatedInput|array
     */
    public function safe(array $keys = null)
    {
        return is_array($keys)
                    ? $this->validator->safe()->only($keys)
                    : $this->validator->safe();
    }

    /**
     * Get the validated data from the request.
     *
     * @return array
     */
    public function validated()
    {
        return $this->validator->validated();
    }

[shaedrich]

I'm not exactly sure but I suppose, I was talking about $reqeust->all() instead of $request->validated() in comparison to $request->safe()

[macropay-solutions]

Anyway, the fix is publicly available in the lib and backward compatible for laravel / lumen >= 8