Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken images on some pages (links to root directory rather than assets) #219

Closed
rufuspollock opened this issue Apr 26, 2023 · 5 comments
Closed
Assignees

Comments

@rufuspollock
Copy link
Member

See e.g. https://web3.lifeitself.org/notes/emmett-2018-rewriting-story-human where images are broken

image

@rufuspollock
Copy link
Member Author

@khalilcodes could you take a quick look to see what's causing this i.e. < 15m or so. (not necessarily fix if that is painful or if you can't work out the issue)

@khalilcodes
Copy link
Contributor

@rufuspollock this is happering because there is no assets folder within site/content (it's at root). The repo uses the old https://github.com/flowershow/remark-wiki-link-plus package and it searches for images within the content folder.

A quick fix is symlinking the assets folder into site/content.

@rufuspollock
Copy link
Member Author

@khalilcodes ok can you do that quick fix. Also can you open an issue about updating to Flowershow (and then we can estimate that).

@khalilcodes
Copy link
Contributor

@rufuspollock Fixed in commit 41760f9 and new issue at #220

@rufuspollock
Copy link
Member Author

FIXED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants