From ad5d19fd06ff5a4fbbb05dd7ba8f187651609bac Mon Sep 17 00:00:00 2001 From: HitanshuPrasad Date: Sat, 30 Dec 2023 20:57:26 +0530 Subject: [PATCH 1/3] Updated Style for Planet Info --- activities/Planets.activity/css/activity.css | 5 +++++ activities/Planets.activity/js/activity.js | 16 ++++++++-------- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/activities/Planets.activity/css/activity.css b/activities/Planets.activity/css/activity.css index adb8a62ac..cb4b601ac 100644 --- a/activities/Planets.activity/css/activity.css +++ b/activities/Planets.activity/css/activity.css @@ -233,6 +233,11 @@ body { margin-top: 25px; } +.info p{ + font-size: 14px; + margin: 4px; + font-weight: 600; +} canvas { position: absolute; top: 0; diff --git a/activities/Planets.activity/js/activity.js b/activities/Planets.activity/js/activity.js index 0a0a79289..d3bddc75e 100644 --- a/activities/Planets.activity/js/activity.js +++ b/activities/Planets.activity/js/activity.js @@ -334,14 +334,14 @@ define(["sugar-web/activity/activity", "sugar-web/env", "sugar-web/datastore", " planetInfo.appendChild(information); } - document.getElementById("Name").innerHTML = '

' + l10n.get("PlanetName") + '
' + l10n.get(name) + '

'; - document.getElementById("Type").innerHTML = '

' + l10n.get("PlanetType") + '
' + l10n.get(type.replace(/\s+/g, '')) + '

'; - document.getElementById("Year").innerHTML = '

' + l10n.get("YearLength") + '
' + l10n.get("EarthDays", {year:year}) + '

'; - document.getElementById("Mass").innerHTML = '

' + l10n.get("Mass") + '
' + mass + '

'; - document.getElementById("Temperature").innerHTML = '

' + l10n.get("SurfaceTemperature") + '
' + temperature + '

'; - document.getElementById("Moons").innerHTML = '

' + l10n.get("NumberOfMoons") + '
' + moons + '

'; - document.getElementById("Radius").innerHTML = '

' + l10n.get("PlanetRadius") + '
' + radius + '

'; - document.getElementById("SunDistance").innerHTML = '

' + l10n.get("SunDistance") + '
' + sunDistance + '

'; + document.getElementById("Name").innerHTML = '

' + l10n.get("PlanetName") + '

' + l10n.get(name) + '

'; + document.getElementById("Type").innerHTML = '

' + l10n.get("PlanetType") + '

' + l10n.get(type.replace(/\s+/g, '')) + '

'; + document.getElementById("Year").innerHTML = '

' + l10n.get("YearLength") + '

' + l10n.get("EarthDays", {year:year}) + '

'; + document.getElementById("Mass").innerHTML = '

' + l10n.get("Mass") + '

' + mass + '

'; + document.getElementById("Temperature").innerHTML = '

' + l10n.get("SurfaceTemperature") + '

' + temperature + '

'; + document.getElementById("Moons").innerHTML = '

' + l10n.get("NumberOfMoons") + '

' + moons + '

'; + document.getElementById("Radius").innerHTML = '

' + l10n.get("PlanetRadius") + '

' + radius + '

'; + document.getElementById("SunDistance").innerHTML = '

' + l10n.get("SunDistance") + '

' + sunDistance + '

'; saveImage = function(){ From 6f7730fd65ebac80fba282b0dfa6008cd106ad2c Mon Sep 17 00:00:00 2001 From: HitanshuPrasad Date: Mon, 1 Jan 2024 13:46:16 +0530 Subject: [PATCH 2/3] Updated Style for Planet Info --- activities/Planets.activity/css/activity.css | 3 +++ 1 file changed, 3 insertions(+) diff --git a/activities/Planets.activity/css/activity.css b/activities/Planets.activity/css/activity.css index cb4b601ac..72621c426 100644 --- a/activities/Planets.activity/css/activity.css +++ b/activities/Planets.activity/css/activity.css @@ -236,6 +236,9 @@ body { .info p{ font-size: 14px; margin: 4px; + +} +.info p:first-of-type{ font-weight: 600; } canvas { From 7aa7bab42cefc4669c07cb5ecd051f2be3103195 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lionel=20Lask=C3=A9?= Date: Fri, 5 Jan 2024 21:19:00 +0100 Subject: [PATCH 3/3] Update CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ccbeb8826..cfd2cfec6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fototoon Activity: interactive buttons appears under the box shape #1221 - "Help" pop-ups nearly impossible to close in Chrome on Mobile #1403 - XSS injections on Labyrinth JS and Paint Activity #787 +- Style for Planet Info in Planet Activity is Hard to See #1448 ## [1.7.0] - 2023-03-28 ### Added