Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[+]Chess Game Fix #1679

Closed
wants to merge 1 commit into from
Closed

Conversation

MostlyKIGuess
Copy link

Fixes #1678 .

Changes Made:

  • Worked on correcting the conditions as per the README of https://github.com/douglasbagnall/p4wn/tree/master .
  • The previous conditions was checking perhaps the possibility of the draw and not the draw actually. So it was not needed.
  • Essentially it was implementing what was already implemented in the engine, check
    P4_MOVE_FLAG_DRAW = 64 a draw is available from the README.

Further Improvements

  • The engine is kind of old, I have added comments to understand what conditions is doing what operations.
  • We can use the engine's p4_move2string function to easy our approach in the game. ( I shall perhaps create an issue on this and then work on this).
  • Further tests from the original library can be added if using the same engine.

@MostlyKIGuess
Copy link
Author

I accidentally made it into main branch. Apologies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unusual Draw in Chess Activity
1 participant