Skip to content

address unused-vars in the no-assert build for PR #213007 - #228986

Merged
sushgokh merged 1 commit into
llvm:mainfrom
sushgokh:features/sgokhale/213007-fixup-unused-vars
Oct 5, 2026
Merged

sushgokh merged 1 commit into
llvm:mainfrom
sushgokh:features/sgokhale/213007-fixup-unused-vars

Conversation

@sushgokh

@sushgokh sushgokh commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@llvmorg-github-actions

llvmorg-github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

@llvm/pr-subscribers-llvm-transforms

@llvm/pr-subscribers-vectorizers

Author: Sushant Gokhale (sushgokh)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/228986.diff

1 Files Affected:

  • (modified) llvm/lib/Transforms/Vectorize/VectorCombine.cpp (+3-5)
diff --git a/llvm/lib/Transforms/Vectorize/VectorCombine.cpp b/llvm/lib/Transforms/Vectorize/VectorCombine.cpp
index dbbc312cf2bd8..f5fe77d8791fc 100644
--- a/llvm/lib/Transforms/Vectorize/VectorCombine.cpp
+++ b/llvm/lib/Transforms/Vectorize/VectorCombine.cpp
@@ -6924,12 +6924,10 @@ bool VectorCombine::foldShuffleOfAdjacentLoads(Instruction &I) {
   //         shuffle 0th operand = HighLoad
   //         shuffle 1st operand = LowLoad
   // Implication with this is shuffle mask for the wide load changes
-  auto RemapMask = [LowLoad, HighLoad, NumElts](ShuffleVectorInst *SV,
-                                                SmallVectorImpl<int> &NewMask) {
+  auto RemapMask = [&](ShuffleVectorInst *SV, SmallVectorImpl<int> &NewMask) {
     Value *SVOp0 = SV->getOperand(0);
-    Value *SVOp1 = SV->getOperand(1);
-    assert(((SVOp0 == LowLoad && SVOp1 == HighLoad) ||
-            (SVOp0 == HighLoad && SVOp1 == LowLoad)) &&
+    assert(((SVOp0 == LowLoad && SV->getOperand(1) == HighLoad) ||
+            (SVOp0 == HighLoad && SV->getOperand(1) == LowLoad)) &&
            "Shuffle operands must be exactly {LowLoad, HighLoad} or {HighLoad, "
            "LowLoad}");
     NewMask.assign(SV->getShuffleMask().begin(), SV->getShuffleMask().end());

@sushgokh
sushgokh merged commit dbeca9a into llvm:main Oct 5, 2026
6 of 8 checks passed
@llvm-ci

llvm-ci commented Oct 5, 2026

Copy link
Copy Markdown

LLVM Buildbot has detected a new failure on builder bolt-aarch64-ubuntu-dylib running on bolt-worker-aarch64 while building llvm at step 6 "test-build-bolt-check-bolt".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/216/builds/6806

Here is the relevant piece of the build log for the reference
Step 6 (test-build-bolt-check-bolt) failure: test (failure)
...
PASS: BOLT :: runtime/AArch64/bti-long-jmp-plt.c (771 of 781)
PASS: BOLT :: AArch64/lite-mode.s (772 of 781)
PASS: BOLT :: X86/callcont-fallthru.s (773 of 781)
PASS: BOLT :: AArch64/veneer-lite-mode.s (774 of 781)
PASS: BOLT :: AArch64/bti-long-jmp.s (775 of 781)
PASS: BOLT :: AArch64/compare-and-branch-split-functions.S (776 of 781)
PASS: BOLT :: AArch64/compare-and-branch-unsupported.S (777 of 781)
PASS: BOLT :: AArch64/long-jmp-one-stub.s (778 of 781)
PASS: BOLT :: AArch64/relax-cross-fragment-calls.s (779 of 781)
TIMEOUT: BOLT :: AArch64/relax-calls.s (780 of 781)
******************** TEST 'BOLT :: AArch64/relax-calls.s' FAILED ********************
Exit Code: -9
Timeout: Reached timeout of 60 seconds

Command Output (stdout):
--
# RUN: at line 5
/home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/llvm-mc -filetype=obj -triple aarch64-unknown-unknown /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/llvm-project/bolt/test/AArch64/relax-calls.s -o /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.o
# executed command: /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/llvm-mc -filetype=obj -triple aarch64-unknown-unknown /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/llvm-project/bolt/test/AArch64/relax-calls.s -o /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.o
# note: command had no output on stdout or stderr
# RUN: at line 6
/usr/bin/python3 /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/llvm-project/bolt/test/link_fdata.py /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/llvm-project/bolt/test/AArch64/relax-calls.s /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.o /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.fdata
# executed command: /usr/bin/python3 /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/llvm-project/bolt/test/link_fdata.py /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/llvm-project/bolt/test/AArch64/relax-calls.s /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.o /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.fdata
# note: command had no output on stdout or stderr
# RUN: at line 7
/home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/llvm-strip --strip-unneeded /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.o
# executed command: /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/llvm-strip --strip-unneeded /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.o
# note: command had no output on stdout or stderr
# RUN: at line 8
/home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/clang  --target=aarch64-unknown-linux-gnu -fPIE -fuse-ld=lld -Wl,--unresolved-symbols=ignore-all -Wl,--build-id=none -pie -mllvm -x86-asm-syntax=att --target=aarch64-unknown-linux-gnu -nostartfiles -nostdlib -ffreestanding -Wl,-z,defs /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.o -o /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.exe -nostdlib -Wl,-q
# executed command: /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/clang --target=aarch64-unknown-linux-gnu -fPIE -fuse-ld=lld -Wl,--unresolved-symbols=ignore-all -Wl,--build-id=none -pie -mllvm -x86-asm-syntax=att --target=aarch64-unknown-linux-gnu -nostartfiles -nostdlib -ffreestanding -Wl,-z,defs /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.o -o /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.exe -nostdlib -Wl,-q
# .---command stderr------------
# | clang: warning: argument unused during compilation: '-mllvm -x86-asm-syntax=att' [-Wunused-command-line-argument]
# `-----------------------------
# RUN: at line 9
/home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/llvm-bolt --runtime-instrumentation-lib=/home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/bolt_rt-bins/lib/libbolt_rt_instr.a --runtime-hugify-lib=/home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/bolt_rt-bins/lib/libbolt_rt_hugify.a /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.exe -o /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.bolt --relax-exp --lite=1 --data /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.fdata    --print-normalized 2>&1 | /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/FileCheck /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/llvm-project/bolt/test/AArch64/relax-calls.s --check-prefix=CHECK-BOLT-LITE
# executed command: /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/llvm-bolt --runtime-instrumentation-lib=/home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/bolt_rt-bins/lib/libbolt_rt_instr.a --runtime-hugify-lib=/home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/bolt_rt-bins/lib/libbolt_rt_hugify.a /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.exe -o /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.bolt --relax-exp --lite=1 --data /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.fdata --print-normalized
# note: command had no output on stdout or stderr
# executed command: /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/FileCheck /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/llvm-project/bolt/test/AArch64/relax-calls.s --check-prefix=CHECK-BOLT-LITE
# note: command had no output on stdout or stderr
# RUN: at line 11
/home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/llvm-bolt --runtime-instrumentation-lib=/home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/bolt_rt-bins/lib/libbolt_rt_instr.a --runtime-hugify-lib=/home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/bolt_rt-bins/lib/libbolt_rt_hugify.a /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.exe -o /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.bolt --relax-exp --lite=0 --data /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.fdata    | /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/FileCheck /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/llvm-project/bolt/test/AArch64/relax-calls.s --check-prefix=CHECK-BOLT
# executed command: /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/llvm-bolt --runtime-instrumentation-lib=/home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/bolt_rt-bins/lib/libbolt_rt_instr.a --runtime-hugify-lib=/home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/bolt_rt-bins/lib/libbolt_rt_hugify.a /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.exe -o /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.bolt --relax-exp --lite=0 --data /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/tools/bolt/test/AArch64/Output/relax-calls.s.tmp.fdata
# .---command stderr------------
# | BOLT-INFO: no .got section found
# `-----------------------------
# executed command: /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/build/bin/FileCheck /home/buildbot/workspace/bolt-aarch64-ubuntu-dylib/llvm-project/bolt/test/AArch64/relax-calls.s --check-prefix=CHECK-BOLT
# note: command had no output on stdout or stderr
# RUN: at line 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants