Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulated equipment could be incorrect #1266

Open
quarklikeadork opened this issue Feb 26, 2023 · 1 comment
Open

simulated equipment could be incorrect #1266

quarklikeadork opened this issue Feb 26, 2023 · 1 comment

Comments

@quarklikeadork
Copy link
Contributor

quarklikeadork commented Feb 26, 2023

Current Behavior

a real adventure runs pre_adv.ash, then equipment maximization, before adventuring,
when a quest simulates if a required stat is available, it simulates only equipment maximization

problem

pre_adv can force equipment in some slots and replace equipment that the simulation was counting on
in theory the equipment changes that are done only in pre_adv can result in failure to reach desired stat

solution

in #1267 where there this could create at least one actual issue with the miniature crystal ball in Twin Peak, solved by duplicating a special part of pre_adv
I don't know if there are other cases with shirt or back items getting replaced by forced equipment, or if they should warrant always simulating pre_adv for equipment

@quarklikeadork
Copy link
Contributor Author

the problem happens if a zone meets both conditions:

  • has important stat requirement
  • pre adv has a secondary objective for the zone. one that the quest script leaves out. like queue manipulation

Twin Peak and The Haunted Boiler Room may be the only 2 zones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant