Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Two default list names hardcoded in Simplified Chinese #662

Closed
3gf8jv4dv opened this issue Dec 21, 2024 · 4 comments
Closed

[Bug] Two default list names hardcoded in Simplified Chinese #662

3gf8jv4dv opened this issue Dec 21, 2024 · 4 comments

Comments

@3gf8jv4dv
Copy link

Afraid you've forgotten, I'd like to hear what you think.

The two default list names are hardcoded in Simplified Chinese. Could this be fixed?

Preview lx-music-mobile-default-lists-name

Originally posted by @3gf8jv4dv in #659 (comment)
lyswhut added a commit that referenced this issue Dec 21, 2024
@lyswhut
修复内置列表名称硬编码的问题（#662）
5302e7b
@lyswhut
Copy link
Owner

lyswhut commented Dec 21, 2024

Try the latest code

@3gf8jv4dv
Copy link
Author

@lyswhut

One problem:

When switching to another language and then returning to your own list page, the yellow highlighted area is still shown as the previously selected language. Changes back to the current language after switching to another list.

Preview lx-music-mobile

@lyswhut
Copy link
Owner

lyswhut commented Dec 21, 2024

Try again, I renamed the translation file

@3gf8jv4dv
Copy link
Author

LGTM. 🥰

@lyswhut lyswhut closed this as completed Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lyswhut @3gf8jv4dv