Failed to compile vorbis-tools

[realaboo]

What I did：
Just run media-autobuild_suite.bat in powershell on a Windows 10 machine, select some build options and then it failed in a mintty window.

make[3]: Entering directory '/build/vorbis-tools-git/build-64bit/oggenc'
  CC       oggenc.o
../../oggenc/oggenc.c:735:30: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'int (*)'; take the address with & [-Wint-conversion]
    while((ret = getopt_long(argc, argv, "a:b:B:c:C:d:G:hkl:L:m:M:n:N:o:P:q:QrR:s:t:VX:Y:",
                             ^~~~
                             &
../../include/getopt.h:140:29: note: passing argument to parameter '__imp___argc' here
extern int getopt_long (int __argc, char *const *__argv, const char *__shortopts,
                            ^
D:/code/mabs/msys64/mingw64/include/stdlib.h:283:19: note: expanded from macro '__argc'
#define __argc (* __MINGW_IMP_SYMBOL(__argc))
                  ^
D:/code/mabs/msys64/mingw64/include/_mingw_mac.h:119:35: note: expanded from macro '__MINGW_IMP_SYMBOL'
#  define __MINGW_IMP_SYMBOL(sym) __imp_##sym
                                  ^
<scratch space>:41:1: note: expanded from here
__imp___argc
^
../../oggenc/oggenc.c:735:36: warning: incompatible pointer types passing 'char **' to parameter of type 'char *const *(*(*)())' [-Wincompatible-pointer-types]
    while((ret = getopt_long(argc, argv, "a:b:B:c:C:d:G:hkl:L:m:M:n:N:o:P:q:QrR:s:t:VX:Y:",
                                   ^~~~
../../include/getopt.h:140:50: note: passing argument to parameter '__p___argv' here
extern int getopt_long (int __argc, char *const *__argv, const char *__shortopts,
                                                 ^
D:/code/mabs/msys64/mingw64/include/stdlib.h:287:19: note: expanded from macro '__argv'
#define __argv  (* __p___argv())
                   ^
1 warning and 1 error generated.

Full log:
oWFK.zip

[Barough]

Just did a test and it compiles just fine here

Running git clone for vorbis-tools...
Running git update for vorbis-tools...
┌ vorbis-tools git ................................... [Recently updated]
├ Running autoreconf...
├ Running configure...
├ Running make...
├ Stripping...
└ vorbis-tools-git ............................................ [Updated]

It seems like your issue is due to using Clang. No issue for me when using GCC

[EDIT]
xiph/vorbis-tools#38

[realaboo]

Just did a test and it compiles just fine here

Running git clone for vorbis-tools... Running git update for vorbis-tools... ┌ vorbis-tools git ................................... [Recently updated] ├ Running autoreconf... ├ Running configure... ├ Running make... ├ Stripping... └ vorbis-tools-git ............................................ [Updated]

It seems like your issue is due to using Clang. No issue for me when using GCC

[EDIT] xiph/vorbis-tools#38

Good point! Will try on gcc. Thanks.

[realaboo]

gcc works. close this issue.

[snoopchallenge]

might wanna reopen this so someone can fix this in their spare time

[1480c1]

Fixed with 4576d38