Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser.GitCommit field to ParseInfo struct #990

Open
stephen-soltesz opened this issue Jun 9, 2021 · 1 comment
Open

Add parser.GitCommit field to ParseInfo struct #990

stephen-soltesz opened this issue Jun 9, 2021 · 1 comment

Comments

@stephen-soltesz
Copy link
Contributor

Since #972, the ETL Version and GitCommit are compiled in at build time. And, the Version is always a human readable symbolic name; either the branch (e.g. sandbox-soltesz, master) or tag (e.g. prod-v0.6.2).

However, the ParseInfo.Version value is chosen using complex logic https://github.com/m-lab/etl/blob/master/parser/parser.go#L25 and the branch names (helpful for for quick identification) do not differentiate new builds.

We should add a new field to the ParseInfo struct for GitCommit that will be inherited by the standard column schemas used in the ndt7, annotation datatypes and simplify the selection logic in parser.go.

@autolabel autolabel bot added the review/triage Team should review and assign priority label Jun 9, 2021
@laiyi-ohlsen laiyi-ohlsen removed the review/triage Team should review and assign priority label Jul 19, 2021
@laiyi-ohlsen
Copy link

Pending deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants