You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since #972, the ETL Version and GitCommit are compiled in at build time. And, the Version is always a human readable symbolic name; either the branch (e.g. sandbox-soltesz, master) or tag (e.g. prod-v0.6.2).
We should add a new field to the ParseInfo struct for GitCommit that will be inherited by the standard column schemas used in the ndt7, annotation datatypes and simplify the selection logic in parser.go.
The text was updated successfully, but these errors were encountered:
Since #972, the ETL
Version
andGitCommit
are compiled in at build time. And, theVersion
is always a human readable symbolic name; either the branch (e.g. sandbox-soltesz, master) or tag (e.g. prod-v0.6.2).However, the
ParseInfo.Version
value is chosen using complex logic https://github.com/m-lab/etl/blob/master/parser/parser.go#L25 and the branch names (helpful for for quick identification) do not differentiate new builds.We should add a new field to the
ParseInfo
struct forGitCommit
that will be inherited by the standard column schemas used in the ndt7, annotation datatypes and simplify the selection logic in parser.go.The text was updated successfully, but these errors were encountered: