Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove annotation from Gardener 2.0 K8S parsers #992

Open
gfr10598 opened this issue Apr 8, 2021 · 2 comments
Open

Remove annotation from Gardener 2.0 K8S parsers #992

gfr10598 opened this issue Apr 8, 2021 · 2 comments
Labels

Comments

@gfr10598
Copy link
Contributor

gfr10598 commented Apr 8, 2021

New parsers should NOT annotate records, as they are annotated by joins in BQ.
The K8S annotation-service should be shut down, and null-annotator should be used for 2.0 parsing tasks.

This would also make the annotator metrics easier to interpret, as they would be legacy pipeline only.

@gfr10598 gfr10598 self-assigned this Apr 8, 2021
@stephen-soltesz
Copy link
Contributor

@gfr10598 can you clarify? We discussed part of this last week. Is this more about cleaning up the annotation metrics? The 2.0 parsers (ndt7 & annotation) do not use the annotation service today. Please update the issue title/description to clarify.

@laiyi-ohlsen laiyi-ohlsen transferred this issue from m-lab/etl-gardener Jun 14, 2021
@autolabel autolabel bot added the review/triage Team should review and assign priority label Jun 14, 2021
@laiyi-ohlsen laiyi-ohlsen added pipeline and removed review/triage Team should review and assign priority labels Jun 14, 2021
@stephen-soltesz
Copy link
Contributor

Working on the local writer for ETL, I discovered that ndt7 (and probably annotation) attempt to contact the annotation-service unnecessarily. The NewSinkParser for ndt7 and annotation services receives a real api.Annotator.

https://github.com/m-lab/etl/blob/master/parser/parser.go#L50

Ideally, this would be a 'noop' for these datatypes and future, migrated types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants