Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics are not well-named #31

Open
pboothe opened this issue Nov 6, 2019 · 0 comments
Open

metrics are not well-named #31

pboothe opened this issue Nov 6, 2019 · 0 comments
Assignees
@pboothe
Labels
backlog P2

Comments

@pboothe
Copy link
Contributor

pboothe commented Nov 6, 2019

When we lint the metrics in this repo, we get the message:

2019/11/06 10:12:06 Bad metric gmx_error_count: counter metrics should have "_total" suffix
2019/11/06 10:12:06 Bad metric gmx_error_count: non-histogram and non-summary metrics should not have "_count" suffix
@pboothe pboothe changed the title metrics are not well-formed metrics are not well-named Nov 6, 2019
@mehtab11 mehtab11 added the P2 label Nov 18, 2019
@autolabel autolabel bot removed the review/triage label Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pboothe pboothe

Labels
backlog P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pboothe @mehtab11