Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename remote_state plugin to backend #298

Open
tleguijt opened this issue Sep 18, 2023 · 1 comment · May be fixed by #297
Open

Rename remote_state plugin to backend #298

tleguijt opened this issue Sep 18, 2023 · 1 comment · May be fixed by #297
Assignees
@tleguijt
Labels
enhancement New feature or request

Comments

@tleguijt
Copy link
Collaborator

Rename plugin to backend since it avoids confusion with the MACH composer plugins, and is more in line with how terraform names it.

We might also consider renaming the values itself;

  • aws -> s3
  • gcp -> gcs
@tleguijt tleguijt added enhancement New feature or request triage Needs triage labels Sep 18, 2023
@tleguijt tleguijt linked a pull request Sep 18, 2023 that will close this issue
Draft
1 task
@demeyerthom demeyerthom removed the triage Needs triage label Sep 19, 2023
@demeyerthom
Copy link
Contributor

demeyerthom commented Sep 27, 2023 •
edited
Loading

We might also want to change remote_state to state as we also support local as an option. So then you get

terraform_config:
  state:
    backend: s3

Obviously we want this to be backwards compatible, so that means a lot of checks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tleguijt tleguijt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rename remote_state plugin to backend mach-composer/mach-composer-cli
2 participants
@tleguijt @demeyerthom