New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace oriented dependencies. #99

Closed

heemankv opened this issue Aug 23, 2024 · 1 comment · Fixed by #115

Assignees

Labels

good first issue

Contributor

heemankv commented Aug 23, 2024

Define all the dependencies at the workspace level and then pull them in each crate.
#81 (comment)

heemankv added the good first issue label

heemankv self-assigned this

heemankv mentioned this issue

Test: Ethereum Settlement Client #81

Merged

Contributor Author

heemankv commented Sep 5, 2024

Going with this convention for PR :

If a dependencies is only being used in a single crate and it's specific to that crate then no need to move it to workspace dependency.
If a dependency is being used in multiple crates but with different features then it should be defined as a workspace dependency and individual features must be pulled in each crate.
If any dependency is being used in many crates without any ifs and buts then we define it as a workspace dependency.

heemankv mentioned this issue

workspace oriented dependencies #115

Merged

heemankv linked a pull request

that will close this issue

workspace oriented dependencies #115

Merged

apoorvsadana closed this as completed in #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment