Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display:none preprocessor #19

Open
nvkelso opened this issue Oct 31, 2011 · 6 comments
Open

display:none preprocessor #19

nvkelso opened this issue Oct 31, 2011 · 6 comments

Comments

@nvkelso
Copy link
Contributor

nvkelso commented Oct 31, 2011

For situations where there is CSS for a class, but the end result is NULL in terms of drawing anything (like line-opacity: 0; where there is no other symbology applied), the data layer should be turned off and the CSS skipped.

@rcoup
Copy link
Contributor

rcoup commented Nov 1, 2011

so special-case 0 for width and opacity and shortcut the symbolizer creation? Any others that spring to mind?

@nvkelso
Copy link
Contributor Author

nvkelso commented Nov 1, 2011

Seems like it should apply to all:

stroke-opacity
polygon-opacity
line-width
outline-width
inline-width
outline-opacity
inline-opacity
point-width
point-height
line-pattern-width
line-pattern-height
shield-size

On Mon, Oct 31, 2011 at 17:22, Robert Coup <
[email protected]>wrote:

so special-case 0 for width and opacity and shortcut the symbolizer
creation? Any others that spring to mind?

Reply to this email directly or view it on GitHub:
#19 (comment)

@migurski
Copy link
Member

migurski commented May 5, 2012

I've gotten display: none working, here's the test on the branch: https://github.com/mapnik/Cascadenik/blob/16afc57c/cascadenik/tests.py#L2065

The opposite of display: none is display: map, and it’s implied for all elements.

I can likely make lines of zero width and so one work as described above too.

@nvkelso
Copy link
Contributor Author

nvkelso commented May 5, 2012

Awesome!

_n

On Fri, May 4, 2012 at 5:10 PM, migurski <
[email protected]

wrote:

I've gotten display: none working, here's the test on the branch:
https://github.com/mapnik/Cascadenik/blob/16afc57c/cascadenik/tests.py#L2065

The opposite of display: none is display: map, and it’s implied for
all elements.

I can likely make lines of zero width and so one work as described above
too.


Reply to this email directly or view it on GitHub:
#19 (comment)

@nvkelso
Copy link
Contributor Author

nvkelso commented Jun 1, 2012

Is this closed now?

@migurski
Copy link
Member

migurski commented Jun 1, 2012

The special-case 0 is still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants