Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Size optimisations #24

Open
1 task done
Tokarak opened this issue Jun 22, 2024 · 3 comments
Open
1 task done

Dockerfile: Size optimisations #24

Tokarak opened this issue Jun 22, 2024 · 3 comments

Comments

@Tokarak
Copy link
Contributor

Tokarak commented Jun 22, 2024

  • switch to latest-rust-slim
    Motivation: cut down on download sizes
    TODO:

  • Remove git binary reference in bot/build.rs. Use crate built instead.

  • Use https://github.com/slimtoolkit/slim

@Tokarak Tokarak changed the title Dockerfile: switch to latest-rust-slim Dockerfile: Size optimisations Jun 22, 2024
@mattfbacon
Copy link
Owner

How is using built related to this? If the problem is using the git binary I'd rather just do std::fs::read_to_string(".git/refs/heads/main").unwrap(), building an entire alternative git client seems like bloat.

@mattfbacon
Copy link
Owner

So I agree with these suggestions in principle but I don't actually use docker so I can't make any progress with this issue. What would you like to do with this?

@Tokarak
Copy link
Contributor Author

Tokarak commented Nov 27, 2024

I'm not sure I have time to work on this unfortunately. Status is as-is: easiest thing, probably, is to Rustify the build process so that rust-slim can be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants