Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the "Using custom elements" guide and related pages, add a disclaimer that WebKit does not plan to support Customized built-in elements #30968

Closed
njanssoone opened this issue Dec 12, 2023 · 2 comments · Fixed by #34947
Labels
area: Web Components Content:WebAPI Web API docs effort: small This task is a small effort. help wanted If you know something about this topic, we would love your help! needs BCD update

Comments

@njanssoone
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/Web_components/Using_custom_elements

What specific section or headline is this issue about?

Types of custom element

What information was incorrect, unhelpful, or incomplete?

The guide does not warn users that using Customized Built-in Elements currently does not work on WebKit-based browsers, and that it won't change for now because the WebKit team is refuting this part of the Web Components spec.

Also, on the "CustomElementRegistry.prototype.define()" page, the compatibility section does show the define method as fully supported by Safari (both desktop and mobile).

What did you expect to see?

In the "Using custom elements" guide, part "Types of custom element": a disclaimer panel indicating that this type of custom elements is currently not supported by WebKit-based browsers.

In the "CustomElementRegistry.prototype.define()" page, part "Browser compatibility": a dedicated row for the { extend: 'tagName' } option's compatibility, indicating WebKit's missing support.

Do you have any supporting links, references, or citations?

https://bugs.webkit.org/show_bug.cgi?id=182671
WebKit/standards-positions#97
WICG/webcomponents#509

Do you have anything more you want to share?

No response

@njanssoone njanssoone added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 12, 2023
@github-actions github-actions bot added the Content:WebAPI Web API docs label Dec 12, 2023
@njanssoone njanssoone changed the title In the "Using custom elements" guide and related pages, add a disclaimer that WebKit does not plant to support Customized built-in elements In the "Using custom elements" guide and related pages, add a disclaimer that WebKit does not plan to support Customized built-in elements Dec 18, 2023
@pepelsbey pepelsbey assigned pepelsbey and unassigned pepelsbey Jan 5, 2024
@pepelsbey pepelsbey added help wanted If you know something about this topic, we would love your help! effort: small This task is a small effort. area: Web Components and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 5, 2024
@pepelsbey
Copy link
Member

Hey! Nice catch :) I just stumbled upon the same part of the guide, but there’s already an issue for that. Thanks! This part of the guide would definitely benefit from clearing this out. It might be in the form of a note, linking to the WebKit’s standard position. Feel free to suggest a PR, or we can wait for the community to pick it up.

As for the compatibility table, this is something that’s based on BCD repository, and there’s a link on top of the table to file an issue with the data. Could you please file a feature request for documenting the extend support?

@davidpcaldwell
Copy link

I filed my own duplicate of this that I'll link for reference. #33063

Here's the gist of what I wrote:

What information was incorrect, unhelpful, or incomplete?

It seems like the page should mention somewhere that (as things stand) "customized built-in elements" will never be widely supported because Safari has decided not to support them on iOS or macOS.

What did you expect to see?

Many MDN pages (for example, the Web Components index page itself) have compatibility information at the bottom.

But even absent that, I think it should probably be mentioned in the introduction to the two custom element types themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Web Components Content:WebAPI Web API docs effort: small This task is a small effort. help wanted If you know something about this topic, we would love your help! needs BCD update
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants