Case sensitivity and regex settings broken

[pcworld]

tree.view.getCellValue returns a string, thus it needs to be parsed (e.g. using === "true"), for both of these values:

thunderbird-subjectcleaner/content/options.js

Lines 89 to 90 in fcc3388

	removal.caseSensitive = tree.view.getCellValue(i, tree.columns.getColumnAt(SubjectCleanerOptions.COLINDEX_CASE_SENSITIVE));
	removal.regexp = tree.view.getCellValue(i, tree.columns.getColumnAt(SubjectCleanerOptions.COLINDEX_REGULAR_EXPRESSION));

Due to that bug, these if conditions are currently broken as the strings "true" and "false" are truthy in JS:

thunderbird-subjectcleaner/content/clean.js

Lines 10 to 19 in d54928f

	var flags = "g";
	if(!removalList[i].caseSensitive){
	flags += "i";
	}
	if(removalList[i].regexp){
	dstSubject = dstSubject.replace(new RegExp(removalList[i].removalString, flags), '');
	}else{
	dstSubject = dstSubject.replace(removalList[i].removalString, '', flags);
	}

Further, case sensitivity setting won't work for non-regexes once the regex setting is fixed, because replace() doesn't have a flags parameter (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace):

thunderbird-subjectcleaner/content/clean.js

Line 18 in d54928f

dstSubject = dstSubject.replace(removalList[i].removalString, '', flags);