Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core key vault firewall should not be set to "Allow public access from all networks" #4250

Open
jonnyry opened this issue Jan 6, 2025 · 0 comments · May be fixed by #4260
Open

Core key vault firewall should not be set to "Allow public access from all networks" #4250

jonnyry opened this issue Jan 6, 2025 · 0 comments · May be fixed by #4260
Labels
story Stories are the smallest unit of work to be done for a project.

Comments

@jonnyry
Copy link
Collaborator

jonnyry commented Jan 6, 2025

Core key vault firewall should not be set to "Allow public access from all networks" since this is the most permissive setting and not required for the TRE to function.
@jonnyry jonnyry added the story Stories are the smallest unit of work to be done for a project. label Jan 6, 2025
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 6, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
27b801d 
…m all networks" microsoft#4250
This was referenced Jan 6, 2025
Open
Closed
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 6, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
6acf7f6 
…m all networks" microsoft#4250
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 6, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
f215a09 
…m all networks" microsoft#4250
@jonnyry jonnyry mentioned this issue Jan 6, 2025
Closed
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
63536c5 
…m all networks" microsoft#4250

Core key vault firewall should not be set to "Allow public access from all networks"

Update keyvault.tf

Add network exceptions via script

Remove azapi use
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
5a6095f 
…m all networks" microsoft#4250
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
a1af191 
…m all networks" microsoft#4250
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
765a36c 
…m all networks" microsoft#4250
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
7036e1f 
…m all networks" microsoft#4250
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
55d43e3 
…m all networks" microsoft#4250
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
724ef08 
…m all networks" microsoft#4250
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
36ee607 
…m all networks" microsoft#4250
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
f582309 
…m all networks" microsoft#4250
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
12c0629 
…m all networks" microsoft#4250
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
2ef7913 
…m all networks" microsoft#4250
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
2f8ad07 
…m all networks" microsoft#4250
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
3121442 
…m all networks" microsoft#4250
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
e0753da 
…m all networks" microsoft#4250
@jonnyry jonnyry linked a pull request Jan 7, 2025 that will close this issue
Open
jonnyry added a commit to nwsde/nwsde-azuretre that referenced this issue Jan 7, 2025
@jonnyry
Core key vault firewall should not be set to "Allow public access fro…
bcdcefc 
…m all networks" microsoft#4250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
story Stories are the smallest unit of work to be done for a project.
Projects
None yet
Milestone
No milestone
1 participant
@jonnyry