New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit jbpf_register_codelet_hook and jbpf_remove_codelet_hook for consistency #20

Open

doctorlai-msrc opened this issue Nov 28, 2024 · 0 comments

Assignees

Collaborator

doctorlai-msrc commented Nov 28, 2024

In jbpf_register_codelet_hook, we assume there won't be duplicate codelet loaded to the hook, and in jbpf_remove_codelet_hook we assume there might be more than one codelet to remove. This is inconsistent.

We should revisit this, either remove L160 or relax the assumption of L60.

xfoukas self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment