Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a codefix for AreSame analyzer #4516

Closed
Youssef1313 opened this issue Jan 4, 2025 · 1 comment · Fixed by #4584
Closed

Implement a codefix for AreSame analyzer #4516

Youssef1313 opened this issue Jan 4, 2025 · 1 comment · Fixed by #4584
Assignees
@Youssef1313
Labels
Area: Analyzers In-PR sprint
Milestone
MSTest 3.8 / Plat...

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jan 4, 2025 •
edited by pavelhorak
Loading

Analyzer implemented in #4493 doesn't have a corresponding codefix.

An implementation of a codefix should be straightforward, just replacing AreSame with AreEqual.

AB#2332313
@Youssef1313 Youssef1313 self-assigned this Jan 4, 2025
@Youssef1313
Copy link
Member Author

The code fix may special case if both arguments are a nullable value type, and switch to two Assert.IsNotNull calls. Otherwise, use Assert.AreEqual

@Youssef1313 Youssef1313 added this to the MSTest 3.8 / Platform 1.6 milestone Jan 7, 2025
@Youssef1313 Youssef1313 mentioned this issue Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
Area: Analyzers In-PR sprint
Projects
None yet
Milestone
MSTest 3.8 / Platform 1.6
Development

Successfully merging a pull request may close this issue.

Implement codefix for 'Are[Not]Same' usage with value types Youssef1313/testfx
1 participant
@Youssef1313