after the update, the underscore is not displayed in the vscode terminal

[AmIaLion]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version:
  Version: 1.89.0
  Commit: b58957e
  Date: 2024-05-01T02:08:25.066Z
  Electron: 28.2.8
  ElectronBuildId: 27744544
  Chromium: 120.0.6099.291
  Node.js: 18.18.2
  V8: 12.0.267.19-electron.0
  OS: Linux x64 6.5.0-28-generic snap
• OS Version: Linux nb-X 6.5.0-28-generic Send a smile > "Submit a bug" should open Github repo #29~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Apr 4 14:39:20 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

Steps to Reproduce:

1. open vscode terminal
2. send mkdir test_dir
   

_ isn't displayed in some cases like pwd or git checkout -b test_branch

it not displayed while typing, but if ctrl+c, ctrl+v it shows.

[meganrogge]

does changing terminal.integrated.gpuAcceleration help?

[AmIaLion]

does changing terminal.integrated.gpuAcceleration help?

It helps when set "canvas", previous setting was "auto"

[kevin-presalytics]

I had this same problem when updating to the new version. Setting terminal.integrated.gpuAcceleration to "canvas" helped for me also.

[pindjur]

Same issue, Linux.
setting terminal.integrated.gpuAcceleration to anything other than "off" fixed it. Was "auto", but now when I updated this setting once, I could not reproduce the issue with "auto", just with "off"

[k98kurz]

Looks like another regression. Same issue #123077 and #35901 before that. Changing font size fixes the display, though then you have to use a font size you did not want.

[bodik]

same here, debian linux 12, "off" uses font variant without underscore visible, any other setting works fine (but also uses little bit different font, change is visible during changing the setting)

[jameshu15869]

I'm seeing the same issue on Code 1.89.1 (dc96b83, 2024-05-07T05:16:23.416Z) on Linux Mint 21.3 - setting terminal.integrated.gpuAcceleration to canvas solved the issue for me

[Mendes11]

Just updated and started having this same issue. If set to canvas it works, anything else don't

Ubuntu Noble

[LincolnCB]

What has worked for me (each works separately):

• Changing the font size to 13 or 15 (underscore is invisible on 14)
• Changing the Terminal Integrated GPU Acceleration to on or canvas
• Changing the Terminal Integrated Line Height to anything above 1.0625 (that seems to be the cutoff)
• Changing the Terminal Font Family (every other one I tried seemed to work)
• Changing the Terminal Integrated Font Weight to anything above 550 (close to bold, seems to be the cutoff)

I'm sticking with the Terminal Integrated GPU Acceleration to on right now, as it changes the least about my terminal's view.

[Tyriar]

This is happening is previously your setup would use the canvas renderer, which was removed as an option for auto in v1.89 and all together in v1.90. The canvas renderer includes some smarts about shifting underscores upwards when they sit particularly low which seems to be the case for some default fonts on Linux. This isn't actually a regression (xtermjs/xterm.js#4067), it's just being hit by more people since the canvas renderer is gone.

Since these issues seem restricted to Linux, I'm thinking for the upcoming release I'll force lineHeight to be 1.1 by default on Linux. Then in the next release come up with a more robust solution for these fonts in xtermjs/xterm.js#4067

---

Recommended workarounds:

1. Set "terminal.integrated.gpuAcceleration": "on" (this might not work)
2. Set "terminal.integrated.lineHeight": 1.1
3. Change "terminal.integrated.fontFamily"

[heck-gd]

I'm still seeing this issue in 1.90.2. The 1.1 workaround doesn't cut it for me. It has to be at least 1.15 for the underscore to be visible.

[zimonitrome]

My problem was that underscores were only invisible for the bottommost line. Presumably hidden below the terminal window.

terminal.integrated.gpuAcceleration only had the options on, off, or auto.

Changing it from auto to off worked.

[Tyriar]

xtermjs/xterm.js#5240 and xtermjs/xterm.js#4067 are tracking trying to remove the overflow CSS rule to workaround this.

[Tyriar]

/duplicate #159110