Incorrect TerminalShellExecution exit code

[njiang747]

Does this issue occur when all extensions are disabled?: Yes/No

• VS Code Version: 1.94.0
• OS Version: macOS Sonoma 14.4

Steps to Reproduce:

1. Listen for onDidEndTerminalShellExecution events
2. Run a command that returns some exit code
3. Type the same command and interrupt with ^C (i.e. interrupt without actually running the command)
4. The exit code reported by the TerminalShellExecution event for the second execution (expected to be undefined since the command didn't actually run) will be the same as the previous command's exit code

For example:

$ echo test^C
-> exit code undefined
$ echo test
-> exit code 0
$ echo test^C
-> exit code 0
$ echo test^C
-> exit code 0
$ echo not test^C
-> exit code undefined
$ echo test^C
-> exit code undefined

From a quick look, this seems like caused by this code (marked as a hack):

vscode/src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts

Lines 360 to 370 in 3b30f94

	// HACK: Handle a special case on some versions of bash where identical commands get merged
	// in the output of `history`, this detects that case and sets the exit code to the the last
	// command's exit code. This covered the majority of cases but will fail if the same command
	// runs with a different exit code, that will need a more robust fix where we send the
	// command ID and exit code over to the capability to adjust there.
	if (exitCode === undefined) {
	const lastCommand = this.commands.length > 0 ? this.commands[this.commands.length - 1] : undefined;
	if (this._currentCommand.command && this._currentCommand.command.length > 0 && lastCommand?.command === this._currentCommand.command) {
	exitCode = lastCommand.exitCode;
	}
	}

[vs-code-engineering]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.96.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!