Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make commit cache in git plugin configurable #726

Open
j-lanson opened this issue Dec 16, 2024 · 0 comments
Open

Make commit cache in git plugin configurable #726

j-lanson opened this issue Dec 16, 2024 · 0 comments
Assignees
Labels
product: plugin Relates to one or more hipcheck-maintained plugins type: enhancement New feature or request

Comments

@j-lanson
Copy link
Collaborator

j-lanson commented Dec 16, 2024

Right now, the plugins/git plugin has an internal Mutex<(.., Vec<RawCommit>) that acts as a cache of RawCommits for the last-queried repo. This is helpful for performance, since we usually will run multiple analyses that run on a single repo and if we can skip re-calcing the RawCommits, it's much faster.

However, right now it's hard-coded to only work for 1 repo. Update the cache size to be configurable through the get_config() gRPC call, and make it default to commit_cache_size = 1.

This will require a version bump to the git plugin.

@j-lanson j-lanson added type: enhancement New feature or request product: plugin Relates to one or more hipcheck-maintained plugins labels Dec 16, 2024
@aamohd aamohd self-assigned this Dec 20, 2024
@aamohd aamohd moved this to In Progress in Hipcheck Product Roadmap Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: plugin Relates to one or more hipcheck-maintained plugins type: enhancement New feature or request
Projects
Status: Todo
Status: In Progress
Development

No branches or pull requests

2 participants