Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase default child process maxBuffer, and make configurable #88

Open
jspahrsummers opened this issue Dec 9, 2024 · 0 comments
Open

Increase default child process maxBuffer, and make configurable #88

jspahrsummers opened this issue Dec 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jspahrsummers
Copy link
Member

From https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback:

maxBuffer Largest amount of data in bytes allowed on stdout or stderr. If exceeded, the child process is terminated and any output is truncated. See caveat at maxBuffer and Unicode. Default: 1024 * 1024.

This (1 MiB) is a pretty low default for MCP on stdio. If exceeded, you'll see an error like the following:

stdout maxBuffer length exceeded

We probably want to bump the default, and make it overridable.
@jspahrsummers jspahrsummers added the enhancement New feature or request label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jspahrsummers