-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run tests on Android emulator #2058
base: main
Are you sure you want to change the base?
Conversation
Failing with:
@larseggert where do I find Mozilla's list of allowed GitHub actions? |
https://github.com/mozilla/neqo/settings/actions under "General" has the list. Let me know if that is not visible to you. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 3001a3a. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
d14254b
to
1edbba7
Compare
@mxinden did you ask for the actions to be allowlisted? Should I? |
I have not gotten to it, sorry. Help appreciated. I assume |
@mxinden these actions should now be available: https://bugzilla.mozilla.org/show_bug.cgi?id=1931529 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2058 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 113 113
Lines 36736 36736
Branches 36736 36736
=======================================
Hits 34260 34260
Misses 1685 1685
Partials 791 791 ☔ View full report in Codecov by Sentry. |
Cross-compilation of NSS for Android on Linux is failing. I will look into this. |
It's probably because it is grabbing the precompiled Linux build for NSS from the action cache. We need to differentiate between Linux and Android when building/caching NSS. |
We need to discuss with the NSS team how they build for Android. I have the suspicion that there are again no instructions, and just the way that the Firefox build does it is working. Topic for Thursday. |
I'm giving up. The build system for NSS and esp. NSPR is just too horrible. It appears the NSS folks don't know how to do an Android build either. So until someone figures this out, this PR is blocked. |
Pendant to quinn-rs/quinn#1950.
Fixes #2028.