Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gecko's browser/base/metrics.yaml should belong to firefox_desktop #377

Open
chutten opened this issue Nov 22, 2021 · 2 comments
Open

gecko's browser/base/metrics.yaml should belong to firefox_desktop #377

chutten opened this issue Nov 22, 2021 · 2 comments

Comments

@chutten
Copy link
Contributor

chutten commented Nov 22, 2021

See discussion in #376, but in summary: Metrics from browser/base/metrics.yaml made it into org_mozilla_firefox via the dependency on gecko, but that metrics file will contain only metrics that are sent as part of firefox_desktop (ie, it belongs to the browser Firefox Desktop alone, not the rendering engine Gecko which is shared with our Android browsers)

It would be tidier if this could be avoided.

@wlach
Copy link
Contributor

wlach commented Nov 22, 2021

I'd probably recommend fixing this sooner than later, before we accumulate more metrics in Firefox for Android.

@chutten
Copy link
Contributor Author

chutten commented Nov 22, 2021

I won't have time for at least a week, so this is free to anyone who wants it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants