Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dry-run for manual invocation #650

Open
badboy opened this issue Nov 3, 2023 · 0 comments
Open

Improve dry-run for manual invocation #650

badboy opened this issue Nov 3, 2023 · 0 comments

Comments

@badboy
Copy link
Member

badboy commented Nov 3, 2023

When adding new libraries/apps we recommend doing a dry-run to ensure probe-scraper is working as expected and without issues.
This however requires deep knowledge about probe-scraper and how it works and with the push-mode it even requires a bit of understanding of that.

Just now we had an issue where a dry-run performed (#645) was fine, until it hit production.
Subsequently I found the "correct" dry-run (#649 (comment)) and that then failed the same as in production.

We should have some mode that automatically does the right thing (pick all dependencies) and document that. Maybe even be able to run that on CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant